fix service-worker in native automation (#8084)

DevExpress · Nov 21, 2023 · 52da69c · 52da69c
1 parent 3461df1
commit 52da69c
Show file tree

Hide file tree

Showing 5 changed files with 83 additions and 5 deletions.
diff --git a/src/native-automation/request-pipeline/index.ts b/src/native-automation/request-pipeline/index.ts
@@ -66,8 +66,9 @@ const ALL_REQUEST_REQUESTS  = { requestStage: 'Response' } as RequestPattern;
 const ALL_REQUESTS_DATA = [ALL_REQUEST_REQUESTS, ALL_REQUEST_RESPONSES];
 
 const TARGET_INFO_TYPE = {
-    iframe: 'iframe',
-    worker: 'worker',
+    iframe:        'iframe',
+    worker:        'worker',
+    serviceWorker: 'service_worker',
 };
 
 export default class NativeAutomationRequestPipeline extends NativeAutomationApiBase {
@@ -401,10 +402,11 @@ export default class NativeAutomationRequestPipeline extends NativeAutomationApi
         // to intercept some requests. We need to use the `sessionId` option
         // in continueRequest/continueResponse/fulfillRequest methods
         await this._client.Target.on('attachedToTarget', async event => {
-            const isIFrame = event.targetInfo.type === TARGET_INFO_TYPE.iframe;
-            const isWorker = event.targetInfo.type === TARGET_INFO_TYPE.worker;
+            const isIFrame        = event.targetInfo.type === TARGET_INFO_TYPE.iframe;
+            const isWorker        = event.targetInfo.type === TARGET_INFO_TYPE.worker;
+            const isServiceWorker = event.targetInfo.type === TARGET_INFO_TYPE.serviceWorker;
 
-            if (!isIFrame && !isWorker)
+            if (!isIFrame && !isWorker && !isServiceWorker)
                 return;
 
             await connectionResetGuard(async () => {

diff --git a/test/functional/fixtures/regression/gh-8054/pages/index.html b/test/functional/fixtures/regression/gh-8054/pages/index.html
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <meta charset="UTF-8">
+    <title>gh-8054</title>
+</head>
+<body>
+<h1>Service worker</h1>
+<button>click me</button>
+<script>
+    const registerServiceWorker = async () => {
+        if ("serviceWorker" in navigator) {
+            try {
+                const serviceWorkerUrl = '/fixtures/regression/gh-8054/pages/sw.js';
+
+                await navigator.serviceWorker.register(serviceWorkerUrl, {
+                    scope: "/fixtures/regression/gh-8054/pages/",
+                });
+            } catch (err) {
+            }
+
+            navigator.serviceWorker.addEventListener('message',
+                (event) => {
+                    if (event.data && event.data.result === 'success') {
+                        document.querySelector('h1').innerHTML = 'Success';
+                    }
+                });
+        }
+    };
+
+    registerServiceWorker();
+
+    document.querySelector('button').addEventListener('click', () => {
+        fetch('/?test' + Date.now());
+    });
+</script>
+</body>
+</html>
diff --git a/test/functional/fixtures/regression/gh-8054/pages/sw.js b/test/functional/fixtures/regression/gh-8054/pages/sw.js
@@ -0,0 +1,18 @@
+self.addEventListener('fetch', event => {
+    if (event.request.url.indexOf('?test') > -1) {
+        event.respondWith(
+            fetch('http://localhost:3000/fixtures/regression/gh-8054/pages/index.html')
+                .then(response => {
+                    self.clients.matchAll().then((clients) => {
+                        clients.forEach((client) => {
+                            client.postMessage({
+                                result: 'success',
+                            });
+                        });
+                    });
+
+                    return response;
+                })
+        );
+    }
+});
diff --git a/test/functional/fixtures/regression/gh-8054/test.js b/test/functional/fixtures/regression/gh-8054/test.js
@@ -0,0 +1,7 @@
+const { onlyInNativeAutomation } = require('../../../utils/skip-in');
+
+describe('Should not ignore request from service worker (GH-8054)', function () {
+    onlyInNativeAutomation('Should not ignore request from service worker (GH-8054)', function () {
+        return runTests('./testcafe-fixtures/index.js');
+    });
+});
diff --git a/test/functional/fixtures/regression/gh-8054/testcafe-fixtures/index.js b/test/functional/fixtures/regression/gh-8054/testcafe-fixtures/index.js
@@ -0,0 +1,13 @@
+import { Selector } from 'testcafe';
+
+fixture `GH-8054 - Should not ignore request from service worker`
+    .page `http://localhost:3000/fixtures/regression/gh-8054/pages/index.html`;
+
+test(`Recreate invisible element and click`, async t => {
+    // NOTE: we need this line for the test. For some reason
+    // service worker is not registered on first loading
+    await t.eval(() => window.location.reload());
+
+    await t.click('button');
+    await t.expect(Selector('h1').innerText).eql('Success');
+});