fix: getClientRectangle method fixed #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Aleksey28
approved these changes
Aug 30, 2024
PavelMor25
approved these changes
Aug 30, 2024
|
Release v31.7.3 addresses this. |
1 similar comment
|
Release v31.7.3 addresses this. |
aleks-pro
pushed a commit
to DevExpress/testcafe
that referenced
this pull request
Sep 16, 2024
<!-- Thank you for your contribution. Before making a PR, please read our contributing guidelines at https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution We recommend creating a *draft* PR, so that you can mark it as 'ready for review' when you are done. --> ## Purpose Hammerhead returned invalid results. ## Approach Update testcafe-hammerhead package. ## References Hammerhead PR: DevExpress/testcafe-hammerhead#3016 Closes: #8237 ## Pre-Merge TODO - [ ] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail --------- Co-authored-by: Bayheck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sometime the first rectangle might have zero width/height which results in error.
Approach
Filter through all rectangles from getClientRects.
References
Testcafe PR: DevExpress/testcafe#8261
Pre-Merge TODO