Chat: Hide title prop and prevent Header rendering #27970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,7 +48,10 @@ class Chat extends Widget<Properties> { | |||
|
|
|||
| super._initMarkup(); | |||
|
|
|||
| this._renderHeader(); | |||
| if (shouldHeaderBeRendered) { | |||
There was a problem hiding this comment.
It is strange to see a magic variable used to prevent the chat header from rendering. It's better to check that the default value has not been changed; that should be sufficient. We discussed this way.
This approach also allows us to test it in the usual way without using global variables or QUnit.skip.
There was a problem hiding this comment.
You are proposing an implementation that is too complex.
There was a problem hiding this comment.
Also, now, we must support all scenarios with title change in runtime
EugeniyKiyashko
previously approved these changes
Aug 29, 2024
pomahtri
approved these changes
Aug 29, 2024
EugeniyKiyashko
approved these changes
Aug 29, 2024
vladaskorohodova
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.