Collection: publish onSelectionChanging event for AutoComplete, List, Lookup, SelectBox, TabPanel, Tabs, TagBox #27954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st, SelectBox, AutoComplete, TagBox, SelectBox
EugeniyKiyashko
changed the title
EugeniyKiyashko
changed the title
ksercs
reviewed
Aug 28, 2024
| * @docid _ui_autocomplete_SelectionChangingEvent.cancel | ||
| * @type Boolean|Promise<Boolean> | ||
| */ | ||
| cancel: boolean | PromiseLike<boolean>; |
There was a problem hiding this comment.
I believe it should be optional
There was a problem hiding this comment.
This argument is not optional because it's presented every time in the onSelectionChanging argument:
https://github.com/EugeniyKiyashko/DevExtreme/blob/24_2_onSelectionChanging_API/packages/devextreme/js/__internal/ui/collection/m_collection_widget.edit.ts#L464-L465
| * @docid _ui_autocomplete_SelectionChangingEvent.cancel | ||
| * @type Boolean|Promise<Boolean> | ||
| */ | ||
| cancel: boolean | PromiseLike<boolean>; |
There was a problem hiding this comment.
Shouldn't we point that default value is false?
There was a problem hiding this comment.
No, it doesn't matter because it will be presented as a table https://js.devexpress.com/jQuery/Documentation/ApiReference/UI_Components/dxPopup/Configuration/#onShowing
ksercs
reviewed
Aug 28, 2024
packages/devextreme/js/ui/collection/ui.collection_widget.base.d.ts
Outdated
Show resolved
Hide resolved
EugeniyKiyashko
changed the title
mpreyskurantov
added a commit
to mpreyskurantov/devextreme-documentation
that referenced
this pull request
Aug 30, 2024
mpreyskurantov
previously approved these changes
Aug 30, 2024
mpreyskurantov
approved these changes
Aug 30, 2024
marker-dao
approved these changes
Aug 30, 2024
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: DevExpress/devextreme-documentation#6586