Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore doc changes on CI #27893

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

IlyaKhD
Copy link
Contributor

@IlyaKhD IlyaKhD commented Aug 9, 2024

Practical Value

This is required to not save time (both human and machine) for PRs with changes in demos' descriptions.

Before

All workflows we triggered for such PRs

After

Regular workflows are not triggered, but the new pr-filter-stubs.yml comes into play. This workflow contains stub jobs that are required to report status for Required Status Checks (RSCs).

  • if PR contains changes ONLY in apps/**/*.md, then all RSCs are reported as skipped (due to stubs, regular RSCs are not triggered)
  • if PR contains changes in apps/**/*.md AND some other files, then
    • both regular RSCs and RSCs stubs are triggered
    • RSCs stubs report to be skipped, BUT GitHub will wait for regular RSCs to complete
    • Changes Segregation task will report an error because changes in apps/**/*.md shouldn't be mixed with changes in other files

@IlyaKhD IlyaKhD added the 24_2 label Aug 9, 2024
@IlyaKhD IlyaKhD self-assigned this Aug 9, 2024
@IlyaKhD IlyaKhD marked this pull request as ready for review August 12, 2024 09:44
@IlyaKhD IlyaKhD requested a review from a team as a code owner August 12, 2024 09:44
@IlyaKhD IlyaKhD marked this pull request as draft August 12, 2024 09:45
@IlyaKhD IlyaKhD force-pushed the khd/ignore-doc-changes-on-ci branch from ad4eddb to 89e47b2 Compare August 12, 2024 09:45
@IlyaKhD IlyaKhD marked this pull request as ready for review August 12, 2024 09:51
@IlyaKhD IlyaKhD marked this pull request as draft August 12, 2024 11:24
@IlyaKhD IlyaKhD force-pushed the khd/ignore-doc-changes-on-ci branch from 495eba4 to 2d6c497 Compare September 4, 2024 18:18
@IlyaKhD IlyaKhD force-pushed the khd/ignore-doc-changes-on-ci branch from 3551fb2 to 4cfa2a8 Compare September 5, 2024 14:50
@IlyaKhD IlyaKhD marked this pull request as ready for review September 6, 2024 07:45
@IlyaKhD IlyaKhD merged commit 95d0236 into DevExpress:24_2 Sep 9, 2024
275 checks passed
@IlyaKhD IlyaKhD deleted the khd/ignore-doc-changes-on-ci branch September 9, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants