DropDownButton: Use isObject instead of isPlainObject to support custom constructors in datasource (T1233565) #27590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zedwag
previously approved these changes
Jun 13, 2024
Zedwag
reviewed
Jun 13, 2024
packages/devextreme/testing/tests/DevExpress.ui.widgets/dropDownButton.tests.js
Outdated
Show resolved
Hide resolved
…wnButton.tests.js Co-authored-by: Alexander Kozlovskiy <[email protected]> Signed-off-by: Anton Kuznetsov <[email protected]>
ksercs
approved these changes
Jun 13, 2024
Zedwag
approved these changes
Jun 13, 2024
nikkithelegendarypokemonster
merged commit 052fafe
into
DevExpress:24_1
269 of 271 checks passed
nikkithelegendarypokemonster
added a commit
to nikkithelegendarypokemonster/DevExtreme
that referenced
this pull request
Jun 14, 2024
…om constructors in datasource (T1233565) (DevExpress#27590) Signed-off-by: Anton Kuznetsov <[email protected]> Co-authored-by: Anton Kuznetsov <[email protected]> Co-authored-by: Alexander Kozlovskiy <[email protected]> # Conflicts: # packages/devextreme/js/__internal/ui/m_drop_down_button.ts
nikkithelegendarypokemonster
added a commit
to nikkithelegendarypokemonster/DevExtreme
that referenced
this pull request
Jun 14, 2024
…om constructors in datasource (T1233565) (DevExpress#27590) Signed-off-by: Anton Kuznetsov <[email protected]> Co-authored-by: Anton Kuznetsov <[email protected]> Co-authored-by: Alexander Kozlovskiy <[email protected]> # Conflicts: # packages/devextreme/js/__internal/ui/m_drop_down_button.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.