Form: Fix form validation error when items are cleared (T1233487) #27435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksercs
requested changes
Jun 12, 2024
There was a problem hiding this comment.
[missed scenario, local solution]
This is only a local solution, it does not work if we specify Form validationGroup property. (Don't forget to add a test)
Moreover, ideologically it's not very good that we make ValidationEngine knows about Form.
I suggest you adding _isRemovable prop to the groupConfig and set it to true when we add a group from Form and other places where it's expected to be non removable.
It will also simplify the condition in _shouldRemoveGroup and make it much more intuitive.
Also I see that there is no test which checks that custom ValidationGroup is not removed after its validators are removed however this case is handled in the code. Please add a test for this.
jdvictoria
force-pushed
the
24_1_Form_T1233487
branch
from
1c192f8 to
4509333
Compare
ksercs
requested changes
Jun 14, 2024
packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.validationRules.tests.js
Outdated
Show resolved
Hide resolved
ksercs
reviewed
Jun 19, 2024
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/validationGroup.tests.js
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.validationRules.tests.js
Outdated
Show resolved
Hide resolved
ksercs
requested changes
Jun 19, 2024
ksercs
approved these changes
Jun 19, 2024
EugeniyKiyashko
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.