Fix remaining CodeQL reports (#28142)

DevExpress · Oct 17, 2024 · f795096 · f795096
1 parent 39a1065
commit f795096
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 86 deletions.
diff --git a/apps/demos/utils/interactive/link-repos.js b/apps/demos/utils/interactive/link-repos.js
diff --git a/apps/demos/utils/interactive/repos-helper.js b/apps/demos/utils/interactive/repos-helper.js
diff --git a/packages/devextreme-monorepo-tools/src/version-utils.ts b/packages/devextreme-monorepo-tools/src/version-utils.ts
@@ -7,11 +7,15 @@ export function validateVersion(version: string | undefined): string {
 }
 
 export function formatVersion(version: string | undefined): string | undefined {
-  if (version?.length && version.length > 1000) {
+  if (version === undefined) {
+    return undefined;
+  }
+
+  if (version.length > 1000) {
     throw new Error("version string is too long");
   }
 
-  return version?.match(/(\d+\.\d+\.\d+)(\D|$)/)?.[1];
+  return version.match(/(\d+\.\d+\.\d+)(\D|$)/)?.[1];
 }
 
 const MSECS_IN_MIN = 1000 * 60;

diff --git a/packages/devextreme/testing/helpers/vectormaputils-tester.js b/packages/devextreme/testing/helpers/vectormaputils-tester.js
@@ -65,10 +65,12 @@ function getRequestInfo(url) {
 
 require('http').createServer(function(request, response) {
     const info = getRequestInfo(request.url);
-    const action = actions[info.action];
     response.writeHead(200, { 'Content-Type': 'text/plain' });
-    if(action && typeof action === 'function') {
-        action(info.arg, callback);
+    if(Object.hasOwn(actions, info.action)) {
+        const action = actions[info.action];
+        if(typeof action === 'function') {
+            action(info.arg, callback);
+        }
     }
     function callback(data) {
         response.end(JSON.stringify(data));