DataGrid - "W1024 - The client-side export is enabled" warning occurs…

… when the exporting feature is used in Angular (T1188932) (#25665)
DevExpress · Sep 27, 2023 · ed5daf4 · ed5daf4
1 parent 3db06ad
commit ed5daf4
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 20 deletions.
diff --git a/js/__internal/grids/data_grid/export/m_export.ts b/js/__internal/grids/data_grid/export/m_export.ts
@@ -608,11 +608,16 @@ export class ExportController extends dataGridCore.ViewController {
     return headersView && headersView.isVisible() ? headersView.getColumnWidths() : rowsView.getColumnWidths();
   }
 
-  init() {
-    if (this.option('export.enabled') && !isDefined(this.option('onExporting'))) {
+  private throwWarningIfNoOnExportingEvent(): void {
+    const hasOnExporting = (this.component as any).hasActionSubscription?.('onExporting');
+
+    if (this.option('export.enabled') && !hasOnExporting) {
       errors.log('W1024');
     }
+  }
 
+  init() {
+    this.throwWarningIfNoOnExportingEvent();
     this._columnsController = this.getController('columns');
     this._rowsView = this.getView('rowsView');
     this._headersView = this.getView('columnHeadersView' as any);
@@ -666,6 +671,13 @@ export class ExportController extends dataGridCore.ViewController {
     }
   }
 
+  optionChanged(args) {
+    super.optionChanged(args);
+    if (args.name === 'export') {
+      this.throwWarningIfNoOnExportingEvent();
+    }
+  }
+
   needLoadItemsOnExportingSelectedItems(): boolean {
     return this.option('loadItemsOnExportingSelectedItems')
       ?? this.getController('data')._dataSource.remoteOperations().filtering;
@@ -838,12 +850,6 @@ dataGridCore.registerModule('export', {
           if (args.name === 'export') {
             args.handled = true;
             this._invalidate();
-
-            if (args.fullName === 'export.enabled') {
-              if (args.value && !isDefined(this.option('onExporting'))) {
-                errors.log('W1024');
-              }
-            }
           }
         },
 

diff --git a/testing/testcafe/tests/dataGrid/export/export.ts b/testing/testcafe/tests/dataGrid/export/export.ts
@@ -21,17 +21,22 @@ test('Warning should be thrown in console if exporting is enabled, but onExporti
   });
 });
 
-test('Warning should be thrown in console if exporting is enabled dynamically, but onExporting is not specified', async (t) => {
-  const dataGrid = new DataGrid(GRID_CONTAINER);
-
-  await dataGrid.option('export.enabled', true);
-
-  const consoleMessages = await t.getBrowserConsoleMessages();
-  const isWarningExist = !!consoleMessages?.warn.find((message) => message.startsWith('W1024'));
-
-  await t.expect(isWarningExist).ok();
-}).before(async () => {
-  await createWidget('dxDataGrid', {
-    dataSource: [],
+([
+  ['export', { enabled: true }],
+  ['export.enabled', true],
+] as const).forEach(([option, value]) => {
+  test(`Warning should be thrown in console if exporting is enabled dynamically with '${option}' option, but onExporting is not specified`, async (t) => {
+    const dataGrid = new DataGrid(GRID_CONTAINER);
+
+    await dataGrid.option(option, value);
+
+    const consoleMessages = await t.getBrowserConsoleMessages();
+    const isWarningExist = !!consoleMessages?.warn.find((message) => message.startsWith('W1024'));
+
+    await t.expect(isWarningExist).ok();
+  }).before(async () => {
+    await createWidget('dxDataGrid', {
+      dataSource: [],
+    });
   });
 });