Skip to content

Commit

Permalink
Revert "Check if dateBox is disposed on valueChanged (T805571) (#9304)…
Browse files Browse the repository at this point in the history
…" (#9318)
  • Loading branch information
mrjohn0011 authored and tar-g committed Aug 16, 2019
1 parent 8d0df10 commit b6a2960
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
2 changes: 1 addition & 1 deletion js/ui/date_box/ui.date_box.mask.js
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ const DateBoxMask = DateBoxBase.inherit({
},

_selectNextPart(step = 0) {
if(!this.option("text") || this._disposed) {
if(!this.option("text")) {
return;
}

Expand Down
12 changes: 0 additions & 12 deletions testing/tests/DevExpress.ui.widgets.editors/datebox.mask.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -640,18 +640,6 @@ if(devices.real().deviceType === "desktop") {
this.keyboard.paste("November 10 2018");
assert.strictEqual(this.$input.val(), "November 10 2018", "pasting correct value is allowed");
});

test("exception should not be thrown when the widget disposed on valueChange", (assert) => {
this.instance.option({
value: new Date(2019, 11, 31),
onValueChanged: function(e) {
e.component.dispose();
}
});

this.keyboard.type("1").blur();
assert.strictEqual(this.$input.val(), "January 31 2019", "value is correct");
});
});


Expand Down

0 comments on commit b6a2960

Please sign in to comment.