TreeList - Select All should work correctly when virtual scrolling is…

… enabled - T1189118 (#25700)
DevExpress · Sep 28, 2023 · 9ecb391 · 9ecb391
1 parent d8051df
commit 9ecb391
Show file tree

Hide file tree

Showing 4 changed files with 70 additions and 2 deletions.
diff --git a/packages/devextreme/js/__internal/grids/tree_list/data_controller/m_data_controller.ts b/packages/devextreme/js/__internal/grids/tree_list/data_controller/m_data_controller.ts
@@ -39,7 +39,7 @@ export const DataController = (dataControllerModule.controllers as any).data.inh
     },
 
     _isItemEquals(item1, item2) {
-      if (!this.callBase.apply(this, arguments)) {
+      if (item1.isSelected !== item2.isSelected) {
         return false;
       }
 
@@ -51,7 +51,18 @@ export const DataController = (dataControllerModule.controllers as any).data.inh
         return false;
       }
 
-      return true;
+      return this.callBase.apply(this, arguments);
+    },
+
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    _isCellChanged(oldRow, newRow, visibleRowIndex, columnIndex, isLiveUpdate) {
+      const firstDataColumnIndex = this._columnsController.getFirstDataColumnIndex();
+
+      if (columnIndex === firstDataColumnIndex && oldRow.isSelected !== newRow.isSelected) {
+        return true;
+      }
+
+      return this.callBase.apply(this, arguments);
     },
 
     init() {

diff --git a/...ests/treeList/etalons/T1189118-treelist-select-all-with-virtual-scrolling-1.png b/...ests/treeList/etalons/T1189118-treelist-select-all-with-virtual-scrolling-1.png
diff --git a/...ests/treeList/etalons/T1189118-treelist-select-all-with-virtual-scrolling-2.png b/...ests/treeList/etalons/T1189118-treelist-select-all-with-virtual-scrolling-2.png
diff --git a/packages/devextreme/testing/testcafe/tests/treeList/scrolling.ts b/packages/devextreme/testing/testcafe/tests/treeList/scrolling.ts
@@ -4,6 +4,7 @@ import url from '../../helpers/getPageUrl';
 import createWidget from '../../helpers/createWidget';
 import { safeSizeTest } from '../../helpers/safeSizeTest';
 import TreeList from '../../model/treeList';
+import CheckBox from '../../model/checkBox';
 
 const scrollWindowTo = async (position: object) => {
   await ClientFunction(
@@ -119,3 +120,59 @@ safeSizeTest('The vertical scroll bar of the container\'s parent should not be d
     $('#container').unwrap();
   })();
 });
+
+// T1189118
+safeSizeTest('All items should be selected after select all and scroll down', async (t) => {
+  // arrange
+  const treeList = new TreeList('#container');
+  const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
+
+  // assert
+  await t
+    .expect(treeList.isReady())
+    .ok();
+
+  // act
+  const selectAllCheckBox = new CheckBox(
+    treeList.getHeaders().getHeaderRow(0).getHeaderCell(0).getEditor().element,
+  );
+
+  await t.click(selectAllCheckBox.element);
+
+  // assert
+  await t
+    .expect(await takeScreenshot('T1189118-treelist-select-all-with-virtual-scrolling-1'))
+    .ok();
+
+  // act
+  await treeList.scrollTo(t, { y: 300 });
+
+  // assert
+  await t
+    .expect(await takeScreenshot('T1189118-treelist-select-all-with-virtual-scrolling-2'))
+    .ok();
+
+  await t
+    .expect(compareResults.isValid())
+    .ok(compareResults.errorMessages());
+}, [800, 800]).before(async () => createWidget('dxTreeList', {
+  dataSource: generateData(100),
+  height: 400,
+  rootValue: -1,
+  columnMinWidth: 80,
+  columnAutoWidth: true,
+  allowColumnResizing: true,
+  keyExpr: 'ID',
+  parentIdExpr: 'Head_ID',
+  showRowLines: true,
+  showBorders: true,
+  autoExpandAll: true,
+  scrolling: {
+    mode: 'virtual',
+  },
+  selection: {
+    allowSelectAll: true,
+    mode: 'multiple',
+  },
+  columns: ['Title', 'Full_Name', 'City'],
+}));