Skip to content

Commit

Permalink
Selection: ignore errors after move to TS
Browse files Browse the repository at this point in the history
  • Loading branch information
EugeniyKiyashko committed Jun 14, 2024
1 parent 2ec143d commit 5bd5018
Show file tree
Hide file tree
Showing 9 changed files with 1,119 additions and 1,073 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* eslint-disable max-classes-per-file */
import $ from '@js/core/renderer';
import { equalByValue } from '@js/core/utils/common';
import type { DeferredObj } from '@js/core/utils/deferred';
import { Deferred } from '@js/core/utils/deferred';
import { extend } from '@js/core/utils/extend';
import { each } from '@js/core/utils/iterator';
Expand All @@ -12,14 +13,14 @@ import eventsEngine from '@js/events/core/events_engine';
import holdEvent from '@js/events/hold';
import { addNamespace, isCommandKeyPressed } from '@js/events/utils/index';
import messageLocalization from '@js/localization/message';
import Selection from '@js/ui/selection/selection';
import errors from '@js/ui/widget/ui.errors';
import type { ColumnHeadersView } from '@ts/grids/grid_core/column_headers/m_column_headers';
import type { ColumnsController } from '@ts/grids/grid_core/columns_controller/m_columns_controller';
import type { ContextMenuController } from '@ts/grids/grid_core/context_menu/m_context_menu';
import type { ModuleType } from '@ts/grids/grid_core/m_types';
import type { StateStoringController } from '@ts/grids/grid_core/state_storing/m_state_storing_core';
import type { RowsView } from '@ts/grids/grid_core/views/m_rows_view';
import Selection from '@ts/ui/selection/m_selection';

import type { DataController } from '../data_controller/m_data_controller';
import modules from '../m_modules';
Expand Down Expand Up @@ -553,7 +554,7 @@ export class SelectionController extends modules.Controller {
return this._selection.loadSelectedItemsWithFilter();
}

public changeItemSelection(visibleItemIndex, keys, setFocusOnly?) {
public changeItemSelection(visibleItemIndex, keys, setFocusOnly?: boolean): boolean | DeferredObj<unknown> | undefined {
keys = keys || {};
if (this.isSelectionWithCheckboxes()) {
keys.control = true;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* eslint-disable max-classes-per-file */
import $ from '@js/core/renderer';
import { equalByValue, noop } from '@js/core/utils/common';
import type { DeferredObj } from '@js/core/utils/deferred';
import { extend } from '@js/core/utils/extend';
import { isDefined } from '@js/core/utils/type';
import type { ColumnHeadersView } from '@ts/grids/grid_core/column_headers/m_column_headers';
Expand Down Expand Up @@ -202,7 +203,8 @@ const selection = (Base: ModuleType<SelectionController>) => class SelectionCont
return super.selectedItemKeys(value, preserve, isDeselect, isSelectAll);
}

public changeItemSelection(itemIndex, keyboardKeys) {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
public changeItemSelection(itemIndex, keyboardKeys, setFocusOnly?: boolean): boolean | DeferredObj<unknown> | undefined {
const isRecursiveSelection = this.isRecursiveSelection();
const callBase = super.changeItemSelection.bind(this);

Expand Down
Loading

0 comments on commit 5bd5018

Please sign in to comment.