fix: revert event batching #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kaushalkapasi
commented
Apr 30, 2024
kaushalkapasi
commented
- reverts event batching, events will be flushed in a single request every flush interval
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @kaushalkapasi - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
-303
to
-312
| let totalEventsCount = events.count | ||
| var startIndex = 0 | ||
| var endIndex = min(self.maxBatchSize, totalEventsCount) | ||
|
|
||
| while startIndex < totalEventsCount { | ||
| let batchEvents = Array(events[startIndex..<endIndex]) | ||
|
|
||
| let requestBody: [String: Any] = [ | ||
| "events": batchEvents, | ||
| "user": user |
There was a problem hiding this comment.
issue (performance): Removal of batching logic could impact performance or functionality.
Consider the implications of sending all events in a single request, such as potential issues with large payloads or server limitations.
jsalaber
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.