Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix release action #196

Merged
merged 1 commit into from
Apr 25, 2024
Merged

chore: Fix release action #196

merged 1 commit into from
Apr 25, 2024

Conversation

kaushalkapasi
Copy link
Collaborator

@kaushalkapasi kaushalkapasi commented Apr 24, 2024 •
edited
Loading

  • update DVCOptions test to use new properties to disable event logging
  • update release action to use v2.3.0

@kaushalkapasi kaushalkapasi requested a review from JamieSinn April 24, 2024 22:33
sourcery-ai[bot]
sourcery-ai bot reviewed Apr 24, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kaushalkapasi - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@kaushalkapasi kaushalkapasi enabled auto-merge (squash) April 25, 2024 16:40
@kaushalkapasi kaushalkapasi merged commit b48e004 into main Apr 25, 2024
10 checks passed
@kaushalkapasi kaushalkapasi deleted the fix-release-action branch April 25, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@jonathannorris jonathannorris jonathannorris approved these changes

@JamieSinn JamieSinn Awaiting requested review from JamieSinn

Assignees
No one assigned
Labels
1 min review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaushalkapasi @jonathannorris