Skip to content

Commit

Permalink
chore: add privacy manifest (#198)
Browse files Browse the repository at this point in the history
* chore: add privacy manifest for accessing user defaults

* Set github auth

* Set github auth for fastlane

* Set to env - not output

* Remove base64 args

* Use https url as we're not using SSH to clone

* Git bearer?

* Git bearer.

* set under match specifically

---------

Co-authored-by: Jamie Sinn <[email protected]>
  • Loading branch information
jsalaber and JamieSinn authored May 16, 2024
1 parent 70202b2 commit ee66bbc
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 16 deletions.
25 changes: 12 additions & 13 deletions .github/workflows/macos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,25 @@ jobs:
steps:
- name: Checkout Project
uses: actions/checkout@v4
- name: 'Select Latest Xcode'
- name: Setup Fastlane Auth
run: echo "FASTLANE_GIT_BASIC_AUTHORIZATION=$(echo -n taplytics-robot:${{ secrets.AUTOMATION_USER_TOKEN }} | base64)" >> "$GITHUB_ENV"
- name: "Select Latest Xcode"
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: latest-stable
- name: 'Set SSH key'
uses: webfactory/[email protected]
with:
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }}
- name: 'Carthage Cached Bootstrap'
uses: DevCycleHQ/carthage-bootstrap@xcframeworks2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
github-token: ${{ secrets.AUTOMATION_USER_TOKEN }}
use-xcframeworks: true
- name: Fastlane macOS Tests
run: fastlane mac tests
env:
DEVELOPER_APP_ID: '${{ secrets.DEVELOPER_APP_ID }}'
MATCH_PASSWORD: '${{ secrets.MATCH_PASSWORD }}'
TEMP_KEYCHAIN_PASSWORD: '${{ secrets.TEMP_KEYCHAIN_PASSWORD }}'
TEMP_KEYCHAIN_USER: '${{ secrets.TEMP_KEYCHAIN_USER }}'
APPLE_KEY_ID: '${{ secrets.APPLE_KEY_ID }}'
APPLE_ISSUER_ID: '${{ secrets.APPLE_ISSUER_ID }}'
APPLE_KEY_CONTENT: '${{ secrets.APPLE_KEY_CONTENT }}'
MATCH_GIT_BASIC_AUTHORIZATION: "${{ env.FASTLANE_GIT_BASIC_AUTHORIZATION }}"
DEVELOPER_APP_ID: "${{ secrets.DEVELOPER_APP_ID }}"
MATCH_PASSWORD: "${{ secrets.MATCH_PASSWORD }}"
TEMP_KEYCHAIN_PASSWORD: "${{ secrets.TEMP_KEYCHAIN_PASSWORD }}"
TEMP_KEYCHAIN_USER: "${{ secrets.TEMP_KEYCHAIN_USER }}"
APPLE_KEY_ID: "${{ secrets.APPLE_KEY_ID }}"
APPLE_ISSUER_ID: "${{ secrets.APPLE_ISSUER_ID }}"
APPLE_KEY_CONTENT: "${{ secrets.APPLE_KEY_CONTENT }}"
7 changes: 7 additions & 0 deletions DevCycle.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
5268DB6B275020F800D17A40 /* DevCycleClientTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5268DB6A275020F800D17A40 /* DevCycleClientTests.swift */; };
5276C9F0275E682B00B9A324 /* DevCycleOptions.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5276C9EF275E682B00B9A324 /* DevCycleOptions.swift */; };
5276C9F2275E6E0D00B9A324 /* DevCycleOptionsTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5276C9F1275E6E0D00B9A324 /* DevCycleOptionsTest.swift */; };
5282C90A2BF50F1D00AF9D0D /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 5282C9092BF50F1D00AF9D0D /* PrivacyInfo.xcprivacy */; };
529CE32328DCBEC2009AB137 /* RequestConsolidator.swift in Sources */ = {isa = PBXBuildFile; fileRef = 529CE32228DCBEC2009AB137 /* RequestConsolidator.swift */; };
529F0C90277374150075AAB4 /* ObjcDVCVariableTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 529F0C8F277374150075AAB4 /* ObjcDVCVariableTests.m */; };
529F0CA52774D6BE0075AAB4 /* URLSessionMock.swift in Sources */ = {isa = PBXBuildFile; fileRef = 529F0CA42774D6BE0075AAB4 /* URLSessionMock.swift */; };
Expand Down Expand Up @@ -111,6 +112,7 @@
5268DB6A275020F800D17A40 /* DevCycleClientTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DevCycleClientTests.swift; sourceTree = "<group>"; };
5276C9EF275E682B00B9A324 /* DevCycleOptions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DevCycleOptions.swift; sourceTree = "<group>"; };
5276C9F1275E6E0D00B9A324 /* DevCycleOptionsTest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DevCycleOptionsTest.swift; sourceTree = "<group>"; };
5282C9092BF50F1D00AF9D0D /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
529CE32228DCBEC2009AB137 /* RequestConsolidator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RequestConsolidator.swift; sourceTree = "<group>"; };
529F0C8F277374150075AAB4 /* ObjcDVCVariableTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = ObjcDVCVariableTests.m; sourceTree = "<group>"; };
529F0CA42774D6BE0075AAB4 /* URLSessionMock.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = URLSessionMock.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -240,6 +242,7 @@
524F4E5F276BDDBD00CB9069 /* DVCVariable.swift */,
5268DB4F27501CFC00D17A40 /* DevCycle.h */,
E673EFC6290093C400C2C4BE /* SSEConnection.swift */,
5282C9092BF50F1D00AF9D0D /* PrivacyInfo.xcprivacy */,
);
path = DevCycle;
sourceTree = "<group>";
Expand Down Expand Up @@ -364,6 +367,9 @@
isa = PBXProject;
attributes = {
BuildIndependentTargetsInParallel = 1;
KnownAssetTags = (
New,
);
LastSwiftUpdateCheck = 1310;
LastUpgradeCheck = 1420;
ORGANIZATIONNAME = Taplytics;
Expand Down Expand Up @@ -401,6 +407,7 @@
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
5282C90A2BF50F1D00AF9D0D /* PrivacyInfo.xcprivacy in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
17 changes: 17 additions & 0 deletions DevCycle/PrivacyInfo.xcprivacy
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>NSPrivacyAccessedAPITypes</key>
<array>
<dict>
<key>NSPrivacyAccessedAPITypeReasons</key>
<array>
<string>CA92.1</string>
</array>
<key>NSPrivacyAccessedAPIType</key>
<string>NSPrivacyAccessedAPICategoryUserDefaults</string>
</dict>
</array>
</dict>
</plist>
5 changes: 4 additions & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ let package = Package(
dependencies: [
.product(name: "LDSwiftEventSource", package: "LDSwiftEventSource")
],
path: "DevCycle"
path: "DevCycle",
resources: [
.process("PrivacyInfo.xcprivacy")
]
),
.testTarget(
name: "DevCycleTests",
Expand Down
4 changes: 2 additions & 2 deletions fastlane/Matchfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
git_url("git@github.com:DevCycleHQ/macOS-certificates.git")

git_url("https://github.com/DevCycleHQ/macOS-certificates.git")
git_branch("main")
storage_mode("git")

platform("macos")
Expand Down

0 comments on commit ee66bbc

Please sign in to comment.