Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup initial NextJS example app #1

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

laurawarr
Copy link
Contributor

@laurawarr laurawarr commented Jan 16, 2024

Setup initial NextJS example app with sample client and server components

Current issues:

  • Client components currently do not receive realtime updates from the SDK. This will require updating the SDK once this is fixed
  • The SDK requires "next": "^14.0.5-canary.*" to work with realtime updates, however npm doesn't consider this to meet the SDK's peer dependency of "next": "^14.0.0". This will cause npm installs to fail until the SDK peer dependencies are updated

@laurawarr laurawarr requested a review from emmawillis January 16, 2024 18:38
@laurawarr laurawarr force-pushed the ACT-116-setup-example-app branch 4 times, most recently from 846dcff to 88cb2dd Compare January 16, 2024 21:06
README.md Outdated
@@ -1,2 +1,30 @@
# example-nextjs-app-router
An example app built using the DevCycle NextJS SDK
# DevCycle React SDK Example App (TypeScript)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be DevCycle NextJS SDK Example App (TypeScript) ?

README.md Outdated
An example app built using the DevCycle NextJS SDK
# DevCycle React SDK Example App (TypeScript)

An example app built using [Next.js](https://nextjs.org/) and the [DevCycle Nest.js SDK](https://docs.devcycle.com/sdk/client-side-sdks/nextjs/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevCycle Nest.js SDK should be Next not Nest, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep 🤦‍♀️

@laurawarr laurawarr force-pushed the ACT-116-setup-example-app branch from 88cb2dd to 561bf56 Compare January 16, 2024 21:19
@laurawarr laurawarr force-pushed the ACT-116-setup-example-app branch from 561bf56 to 211883a Compare January 16, 2024 21:38
@laurawarr laurawarr force-pushed the ACT-116-setup-example-app branch from 211883a to 5f96743 Compare January 16, 2024 21:39
@laurawarr laurawarr merged commit fc800a4 into main Jan 16, 2024
1 check passed
@laurawarr laurawarr deleted the ACT-116-setup-example-app branch January 16, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants