Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove and do not reference out-of-date pages #108

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Collaborator

@wesleyboar wesleyboar commented Dec 18, 2024

@wesleyboar wesleyboar marked this pull request as draft December 18, 2024 01:13
Copy link
Collaborator Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for reviewers.

Comment on lines -116 to -118
# the following have been moved to the user guide. we need to remove these files from the directory in use cases, but doing so would break `{% include-markdown '../usecases/haan/usecase` in `user-guide/docs/tools/visualization.md`
# - Basic Image Browsing and Mapping: usecases/haan/usecase.md
# - Grouping and Tagging Image Files: usecases/haan/usecase-2.md
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved via #105.

Comment on lines -105 to -111
# - Use Cases Flat:
# - Overview: usecases/overview.md
# - Data Analytics: usecases/dataanalyticsusecases.md
# - GeoHazard: usecases/geohazardusecases.md
# - Seismic: usecases/seismicusecases.md
# - Wind and Storm Surge: usecases/windstormsurgeusecases.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I deleted these files, I think I need not archive old links to them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed <a> to <article> and removing href.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to update this because it was all about files I deleted.

[class*=card--]:hover :is( .h1, .h2, .h3, .h4, .h5, .h6 ) {
a[class*=card--]:hover :is( .h1, .h2, .h3, .h4, .h5, .h6 ) {
Copy link
Collaborator Author

@wesleyboar wesleyboar Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed bug that only showed when I changed cards to not be links.

@wesleyboar wesleyboar marked this pull request as ready for review December 18, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant