Skip to content

Commit

Permalink
Make ng serve work in container again
Browse files Browse the repository at this point in the history
Signed-off-by: Johannes Ott <[email protected]>
  • Loading branch information
DerOetzi committed May 25, 2024
1 parent c7f6def commit 6873617
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
13 changes: 3 additions & 10 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
{
"name": "Python 3",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/python:0-3.10",
"image": "mcr.microsoft.com/devcontainers/python:0-3.11",
"features": {
"ghcr.io/devcontainers/features/node:1": {
"nodeGypDependencies": true,
"version": "18"
"version": "20"
},
"ghcr.io/devcontainers-contrib/features/act:1": {
"version": "latest"
Expand All @@ -17,20 +17,16 @@
},
"ghcr.io/stuartleeks/dev-container-features/shell-history:0": {}
},

// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
"forwardPorts": [
4200,
5000
],
"customizations": {
"vscode": {
"extensions": [
"Angular.ng-template",
"ms-python.autopep8",
"dbaeumer.vscode-eslint",
"SonarSource.sonarlint-vscode",
"ms-python.isort",
Expand All @@ -42,13 +38,10 @@
]
}
}

// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "pip3 install --user -r requirements.txt",

// Configure tool-specific properties.
// "customizations": {},

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
}
3 changes: 0 additions & 3 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@
"--trailing-comma"
],
"python.envFile": "${workspaceFolder}/core/.env",
"[python]": {
"editor.defaultFormatter": "ms-python.autopep8"
},
"python.formatting.provider": "none",
"colorTabs.config": [
{
Expand Down
4 changes: 4 additions & 0 deletions ui/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"host": "0.0.0.0",
"port": 4200
},
"configurations": {
"production": {
"buildTarget": "learninghouse:build:production"
Expand Down

0 comments on commit 6873617

Please sign in to comment.