Support Ruby3 #321
Merged
Support Ruby3 #321
+139
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a shame that we haven't supported Ruby 3.x. This patch prevent users to be confused due to runtime ruby version.
jmatsu
commented
May 13, 2024
| @@ -12,6 +12,7 @@ | |||
| require "gem_update_checker" | |||
| require "active_support/core_ext/time" | |||
| require "active_support/core_ext/hash" | |||
| require "active_support/core_ext/integer/time" | |||
There was a problem hiding this comment.
active support has moved Numeric extension like 1.days from core_ext/time to here.
jmatsu
commented
May 13, 2024
| @@ -60,7 +60,7 @@ def headers | |||
| extheaders = BASE_HEADERS.dup | |||
|
|
|||
| unless @token.nil? | |||
| extheaders.push(['AUTHORIZATION', @token]) | |||
| extheaders.push(['AUTHORIZATION', "token #{@token}"]) | |||
There was a problem hiding this comment.
The token header prefix is preferred.
jmatsu
commented
May 13, 2024
| @@ -2,7 +2,6 @@ module DeployGate | |||
| module Commands | |||
| module Deploy | |||
| class Push | |||
| BASE_URL = 'https://deploygate.com' | |||
satsukies
approved these changes
May 14, 2024
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v4 |
| @@ -28,14 +30,15 @@ POST_INSTALL_MESSAGE | |||
| spec.add_runtime_dependency 'highline', '~> 2.0' | |||
| spec.add_runtime_dependency 'uuid', '~> 2.3' | |||
| spec.add_runtime_dependency 'gem_update_checker', '~> 0.2' | |||
| spec.add_runtime_dependency 'activesupport', '~> 4.2' | |||
| spec.add_runtime_dependency 'i18n', '~> 0.7' | |||
There was a problem hiding this comment.
I understand to delete this line because i18n gem was bundled with after Rails3.
|
Thanks~ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is really clear. For Ruby3 support, this PR upgrade ActiveSupport and adds
webrickto dependencies cuz Ruby 3 has droppedwebrickfrom bundled gems.