Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict multi_xml version on Ruby 3.0 or lower #317

Merged
merged 2 commits into from
May 2, 2024

Conversation

jmatsu
Copy link
Contributor

@jmatsu jmatsu commented May 2, 2024

multi_xml is required by httparty with the relaxed constraint >= 0.5.2 so it now includes versions that support Ruby 3.1 or higher.

https://rubygems.org/gems/multi_xml/versions/0.7.0

gemspec is evaluated during the release process so Gemfile is it.

jmatsu added 2 commits May 2, 2024 14:16
multi_xml is required by httparty with the relaxed constraint so it now includes versions that support Ruby 3.1 or higher.

https://rubygems.org/gems/multi_xml/versions/0.7.0
@jmatsu jmatsu requested review from a team and satsukies and removed request for a team May 2, 2024 06:34
@jmatsu jmatsu changed the title Restrict multi_xlm version on Ruby 3.0 or lower Restrict multi_xml version on Ruby 3.0 or lower May 2, 2024
Copy link
Member

@satsukies satsukies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the background.
Looks good to me this change provides the correct behavior 👍

@jmatsu
Copy link
Contributor Author

jmatsu commented May 2, 2024

Thanks~

@jmatsu jmatsu merged commit e82c1b2 into master May 2, 2024
3 checks passed
@jmatsu jmatsu deleted the jmatsu/fix/multi_xml_constraint branch May 2, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants