Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new callback interface to receive the Capture creation event #96

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

satsukies
Copy link
Member

@satsukies satsukies commented Aug 22, 2024

We provide the callback interface to notify of finished create the Capture.
You can trigger any process when the Capture is successfully created.
e.g. logging application states, saving snapshot data, etc...

@satsukies satsukies self-assigned this Aug 22, 2024
@satsukies satsukies changed the title WIP: Add new callback interface to receive the Capture creation event Add new callback interface to receive the Capture creation event Aug 23, 2024
@satsukies satsukies marked this pull request as ready for review August 23, 2024 02:31
Comment on lines +50 to +67
initializeCallback = new DeployGateInitializeCallback() {
@Override
public void onInitialized(boolean isServiceAvailable) {
// no-op
}
};
statusChangeCallback = new DeployGateStatusChangeCallback() {
@Override
public void onStatusChanged(boolean isManaged, boolean isAuthorized, String loginUsername, boolean isStopped) {
// no-op
}
};
updateAvailableCallback = new DeployGateUpdateAvailableCallback() {
@Override
public void onUpdateAvailable(int revision, String versionName, int versionCode) {
// no-op
}
};
Copy link
Member Author

@satsukies satsukies Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to initialize these variables, so I fixed them.
Ref. #95

@satsukies satsukies requested a review from jmatsu August 23, 2024 02:39
Copy link
Contributor

@jmatsu jmatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the CI status.

@satsukies
Copy link
Member Author

@jmatsu
Sorry, I fixed some code. Now CI status is back to green.

@satsukies satsukies requested a review from jmatsu August 26, 2024 08:19
Copy link
Contributor

@jmatsu jmatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satsukies
Copy link
Member Author

Thank you!

@satsukies satsukies merged commit 95b8e74 into master Aug 26, 2024
6 checks passed
@satsukies satsukies deleted the feat/add-callback-on-capture-created branch August 26, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants