Support scheme v3.1 #122
Merged
Support scheme v3.1 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmatsu
commented
Oct 31, 2023
| signers[sdk_versions].push(line) | ||
| end | ||
| else | ||
| # TODO: support multiple signers |
There was a problem hiding this comment.
Multiple key signing is not supported by Google Play or the general usecase of App Bundle, so this has been to TODOs.
jmatsu
commented
Oct 31, 2023
| attr_reader :trusted_signature_lineage | ||
| # An object contains lineages and certificate fingerprints | ||
| # @return [AndroidApk::AppSignature] a signature representation | ||
| attr_reader :app_signature |
There was a problem hiding this comment.
This exposes v1, v2, v3, v3.1 compatible interfaces.
jmatsu
commented
Oct 31, 2023
jmatsu
requested review from
a team and
satsukies
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.1 introduces target sdk ability so this PR adds interfaces to return signature information with target sdk.