remove can_register_vac variable #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eugh. This failing build is going to be because 3.12.8 came out yesterday |
|
The (removal of) code here is fine, but I'm 100% sure the EC will want to show this information for May 25...it was clearly an oversight not to have included it already. Not sure if that changes anything: is it worth removing to re-add in the next couple of months? Or should we just plan how to add it properly? I'll ask them at the next meeting |
symroe
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs https://app.asana.com/0/1204880927741389/1208687275764620/f
I was going through our code to see if there is anywhere we are presenting the VAC application deadline with a view to making sure we only show it in relevant situations (due to DemocracyClub/uk-election-timetables#47 )
My conclusion from looking at this repo is that we never present this information. We set this
can_register_vacvariable, but then it is never referenced in any template. Maybe we intended to at some point. Lets delete this and we'll come back to it if we ever decide to implement this.