[emojicoin] Add fees #2140
Open
[emojicoin] Add fees #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The emojicoin.ts adapter exports: |
gregnazario
force-pushed
the
emojicoin
branch
from
f9e4ed3
to
991d99f
Compare
|
The emojicoin.ts adapter exports: |
xbtmatt
reviewed
Nov 28, 2024
| @@ -1,22 +1,29 @@ | |||
| import { httpGet } from "../utils/fetchURL"; | |||
| import {httpGet, httpPost} from "../utils/fetchURL"; | |||
|
|
|||
| export const APTOS_PRC = 'https://aptos-mainnet.pontem.network'; | |||
There was a problem hiding this comment.
Suggested change
| export const APTOS_PRC = 'https://aptos-mainnet.pontem.network'; | |
| export const APTOS_RPC = 'https://aptos-mainnet.pontem.network'; |
| let lastData: any; | ||
| let cursor | ||
| do { | ||
| let url = `${APTOS_PRC}/v1/accounts/${account}/resources?limit=9999` |
There was a problem hiding this comment.
Suggested change
| let url = `${APTOS_PRC}/v1/accounts/${account}/resources?limit=9999` | |
| let url = `${APTOS_RPC}/v1/accounts/${account}/resources?limit=9999` |
| return { | ||
| totalFees: `${totalFees}`, | ||
| dailyFees: `${dailyFees}`, | ||
| // TODO: revenue |
There was a problem hiding this comment.
The revenue can just be the integrator fees (what you're already using for total/daily)
g1nt0ki
reviewed
Nov 28, 2024
|
|
||
| const ONE_DAY: number = (24 * 60 * 60 * 1000); | ||
|
|
||
| const fetch = async (timestamp: number) => { |
There was a problem hiding this comment.
change this to adapter version 2, then you get start and endTimestamp as part of input
g1nt0ki
reviewed
Nov 28, 2024
| const yesterdayRegistry = await registryView(BigInt(closestToPreviousDate)) | ||
| const todayRegistry = await registryView(BigInt(closestToDate)) | ||
|
|
||
| const prices = await getPrices(["coingecko:aptos"], timestamp) |
There was a problem hiding this comment.
avoid pulling token prices and change code to something like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.