-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add live view to cells #88
Open
GlennGeelen
wants to merge
1
commit into
DefactoSoftware:master
Choose a base branch
from
GlennGeelen:glenn/add-live-cells
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
defmodule ExCell.LiveView do | ||
@moduledoc """ | ||
Cell helpers used to render the live view cells in both Views and Cells | ||
""" | ||
@view_adapter ExCell.config(:view_adapter, Phoenix.LiveView) | ||
|
||
@doc """ | ||
Renders a cell in the view. | ||
### Examples | ||
iex(0)> safe_to_string(AppWeb.AvatarView.live_cell(AvatarLiveCell, socket)) | ||
"<div class=\"AvatarLiveCell\" ...>" | ||
""" | ||
def live_cell(cell, conn_or_socket) do | ||
render_cell(cell, conn_or_socket, []) | ||
end | ||
|
||
@doc """ | ||
Renders a cell in the view with children. | ||
### Examples | ||
iex(0)> safe_to_string(AppWeb.AvatarView.live_cell(AvatarLiveCell, do: "Foo")) | ||
"<div class=\"AvatarLiveCell\" ...>Foo</div>" | ||
""" | ||
def live_cell(cell, conn_or_socket, do: children) do | ||
render_cell(cell, conn_or_socket, children: children) | ||
end | ||
|
||
@doc """ | ||
Renders a cell in the view with assigns. | ||
### Examples | ||
iex(0)> safe_to_string(AppWeb.AvatarView.live_cell(AvatarLiveCell, user: %User{name: "Bar"})) | ||
"<div class=\"AvatarLiveCell\" ...>Bar</div>" | ||
""" | ||
def live_cell(cell, conn_or_socket, assigns) when is_list(assigns) do | ||
render_cell(cell, conn_or_socket, assigns) | ||
end | ||
|
||
@doc """ | ||
Renders a cell in the view with children without a block. | ||
### Examples | ||
iex(0)> safe_to_string(AppWeb.AvatarView.live_cell(AvatarLiveCell, "Hello")) | ||
"<div class=\"AvatarLiveCell\" ...>Hello</div>" | ||
""" | ||
def live_cell(cell, conn_or_socket, children) do | ||
render_cell(cell, conn_or_socket, children: children) | ||
end | ||
|
||
def live_cell(cell, conn_or_socket, assigns, do: children) when is_list(assigns) do | ||
render_cell(cell, conn_or_socket, [children: children] ++ assigns) | ||
end | ||
|
||
def live_cell(cell, conn_or_socket, children, assigns) when is_list(assigns) do | ||
render_cell(cell, conn_or_socket, [children: children] ++ assigns) | ||
end | ||
|
||
defp render_cell(cell, conn_or_socket, assigns) do | ||
assigns = Map.new(assigns) | ||
@view_adapter.live_render(conn_or_socket, cell, session: %{assigns: assigns}) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
defmodule ExCell.LiveViewTest do | ||
use ExCell.ConnCase | ||
alias ExCell.LiveView | ||
|
||
test "live_cell/2 with ExCell", %{conn: conn} do | ||
assert LiveView.live_cell(:mock_cell, conn) === [conn, :mock_cell, [session: %{assigns: %{}}]] | ||
end | ||
|
||
test "live_cell/3 with assigns", %{conn: conn} do | ||
assert LiveView.live_cell(:mock_cell, conn, foo: "bar") === [ | ||
conn, | ||
:mock_cell, | ||
[session: %{assigns: %{foo: "bar"}}] | ||
] | ||
end | ||
|
||
test "live_cell/3 with do block", %{conn: conn} do | ||
assert LiveView.live_cell(:mock_cell, conn, do: "yes") === [ | ||
conn, | ||
:mock_cell, | ||
[session: %{assigns: %{children: "yes"}}] | ||
] | ||
end | ||
|
||
test "live_cell/3 with children", %{conn: conn} do | ||
assert LiveView.live_cell(:mock_cell, conn, "yes") === [ | ||
conn, | ||
:mock_cell, | ||
[session: %{assigns: %{children: "yes"}}] | ||
] | ||
end | ||
|
||
test "live_cell/3 with assign and do block", %{conn: conn} do | ||
assert LiveView.live_cell(:mock_cell, conn, [foo: "bar"], do: "yes") === [ | ||
conn, | ||
:mock_cell, | ||
[session: %{assigns: %{children: "yes", foo: "bar"}}] | ||
] | ||
end | ||
|
||
test "live_cell/3 with children and assign", %{conn: conn} do | ||
assert LiveView.live_cell(:mock_cell, conn, "yes", foo: "bar") === [ | ||
conn, | ||
:mock_cell, | ||
[session: %{assigns: %{children: "yes", foo: "bar"}}] | ||
] | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
defmodule ExCell.ConnCase do | ||
@moduledoc """ | ||
This module defines the test case to be used by | ||
tests that require setting up a connection. | ||
Such tests rely on `Phoenix.ConnTest` and also | ||
import other functionality to make it easier | ||
to build common data structures and query the data layer. | ||
Finally, if the test case interacts with the database, | ||
it cannot be async. For this reason, every test runs | ||
inside a transaction which is reset at the beginning | ||
of the test unless the test case is marked as async. | ||
""" | ||
|
||
use ExUnit.CaseTemplate | ||
|
||
using do | ||
quote do | ||
# Import conveniences for testing with connections | ||
use Phoenix.ConnTest | ||
end | ||
end | ||
|
||
setup _tags do | ||
{:ok, conn: Phoenix.ConnTest.build_conn()} | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also make another file
mock_live_view_adapter
with this function, if that is preferred?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need IMO