Skip to content

Commit

Permalink
Small clean-ups
Browse files Browse the repository at this point in the history
  • Loading branch information
brunchboy committed Dec 1, 2024
1 parent 42ea2fd commit 8740dcb
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -744,8 +744,8 @@ May the Fourth be with you.

### Changed

- Device updates, beat announcements, and master announcements are time
sensitive, so they are now delivered directly on the thread that is
- Device updates, beat announcements, and master announcements are
time-sensitive, so they are now delivered directly on the thread that is
receiving them from the network, rather than being added to the Event
Dispatch Queue. This will reduce latency, but means listener methods
need to be very fast, and delegate any lengthy, non-time-sensitive
Expand Down
7 changes: 4 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ great.
First of all, we would *love* to hear from you! We have no way of
knowing who has discovered, explored, downloaded and tried Beat Link.
So if you have, please write a quick note on the [Beat Link Trigger Zulip
stream](https://deep-symmetry.zulipchat.com/#narrow/stream/275322-beat-link-trigger)
channel](https://deep-symmetry.zulipchat.com/#narrow/stream/275322-beat-link-trigger)
to let us know! Even if it is only to explain why it didn’t
quite work for you.

Expand Down Expand Up @@ -44,8 +44,9 @@ Once you have something working you’d like to share, you can open a
[pull request][pulls].

Or if you simply have an idea, or something that you wish worked
differently, feel free to open an [issue][issues] if it seems like
nobody already has.
differently, feel free to discuss it on the [Beat Link Trigger Zulip
channel](https://deep-symmetry.zulipchat.com/#narrow/stream/275322-beat-link-trigger), and if directed to do so by the community there, open
an [issue][issues].

## Maintainers

Expand Down
7 changes: 4 additions & 3 deletions src/main/java/org/deepsymmetry/beatlink/VirtualCdj.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
*
* @author James Elliott
*/
@SuppressWarnings("LoggingSimilarMessage")
@API(status = API.Status.STABLE)
public class VirtualCdj extends LifecycleParticipant {

Expand Down Expand Up @@ -927,9 +928,9 @@ private boolean createVirtualCdj() throws SocketException {
}

// Copy the chosen interface's hardware and IP addresses into the announcement packet template
byte[] addr = matchingInterfaces.get(0).getHardwareAddress();
if (addr != null) {
System.arraycopy(addr, 0, keepAliveBytes, MAC_ADDRESS_OFFSET, 6);
byte[] address = matchingInterfaces.get(0).getHardwareAddress();
if (address != null) {
System.arraycopy(address, 0, keepAliveBytes, MAC_ADDRESS_OFFSET, 6);
}
System.arraycopy(matchedAddress.getAddress().getAddress(), 0, keepAliveBytes, 44, 4);
broadcastAddress.set(matchedAddress.getBroadcast());
Expand Down

0 comments on commit 8740dcb

Please sign in to comment.