Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M farouk b patch 3 #90

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

M farouk b patch 3 #90

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
920a01d
Update save.R
MFaroukB Apr 8, 2019
c287761
Update save.R
MFaroukB Apr 8, 2019
69d363f
Update save.R
MFaroukB Apr 9, 2019
6bba564
Merge pull request #3 from MFaroukB/MFaroukB-patch-4
MFaroukB Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/save.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#' @rdname plot_carp
#' @export
saveviz <- function(x, ...) {
saveviz <- function(x,frames_number,frame_rate, ...) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be arguments of the saveviz.CARP and saveviz.CBASS methods only - not the generic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be documented (for the methods) -- see how the other arguments are documented below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These also need default values.

UseMethod("saveviz", x)
}

Expand Down Expand Up @@ -101,7 +101,7 @@ saveviz.CARP <- function(x,
percent.seq = percent.seq)
animation::ani.options(ani.width = convert_units(width, from = units, to = "px"),
ani.height = convert_units(height, from = units, to = "px"))
gganimate::anim_save(filename = file.name, animation = animate(p))
gganimate::anim_save(filename = file.name, animation = animate(p, nframes = frames_number, fps = frame_rate))
invisible(file.name)
},
dendrogram = {
Expand Down