Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMD-1023 add returnAddress #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

festelo
Copy link
Collaborator

@festelo festelo commented May 10, 2021

No description provided.

@ltfschoen ltfschoen self-requested a review May 11, 2021 10:02
Copy link

@ltfschoen ltfschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we please add appropriate tests in the https://github.com/DataHighway-DHX/deployer/tree/main/tests, similar to those in https://github.com/DataHighway-DHX/mining/tree/master/test, which also include testing that the returnAddress functionality fully works

and then check that the tests fail when we try to use contracts from https://github.com/DataHighway-DHX/mining/tree/master/contracts that don't allow the user to specify a returnAddress, and then modify the code in that other repo so that a user who provides specific return address has all their funds returned to that address, and otherwise the funds are returned by default to the address that originally locked or signalled, and exhaust all the different things they have to do to have the funds returned, or whether it's done automatically.

@festelo
Copy link
Collaborator Author

festelo commented Jun 10, 2021

could we please add appropriate tests in the https://github.com/DataHighway-DHX/deployer/tree/main/tests, similar to those in https://github.com/DataHighway-DHX/mining/tree/master/test

it's a lot easier to test contract only at https://github.com/DataHighway-DHX/mining/tree/main/tests and test only deployer itself in deployer in deployer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants