Let's use the right API for tags

DataDrake · Aug 4, 2018 · 364a583 · 364a583
1 parent 7a3e69b
commit 364a583
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/providers/github/provider.go b/providers/github/provider.go
@@ -31,7 +31,7 @@ const (
 	// APIReleases is a format string for the Releases API
 	APIReleases = "https://api.github.com/repos/%s/releases"
 	// APITags is a format string for the Tags API
-	APITags = "https://api.github.com/repos/%s/git/refs/tags"
+	APITags = "https://api.github.com/repos/%s/tags"
 	// SourceFormat is the format string for Github release tarballs
 	SourceFormat = "https://github.com/%s/archive/%s.tar.gz"
 )
@@ -67,7 +67,7 @@ func (c Provider) Latest(name string) (r *results.Result, s results.Status) {
 		if s != results.OK || rs.Empty() {
 			return
 		}
-		r = rs.Last()
+		r = rs.First()
 		return
 	default:
 		s = results.Unavailable

diff --git a/providers/github/tags.go b/providers/github/tags.go
@@ -24,15 +24,15 @@ import (
 
 // Tag is a JSON representation of a Github tag
 type Tag struct {
-	Ref string `json:"ref"`
+	Name string `json:"name"`
 }
 
 // Convert turns a Github tag into a Cuppa result
 func (t *Tag) Convert(name string) *results.Result {
 	r := &results.Result{}
 	pieces := strings.Split(name, "/")
 	r.Name = pieces[len(pieces)-1]
-	pieces = strings.Split(t.Ref, "/")
+	pieces = strings.Split(t.Name, "/")
 	r.Version = pieces[len(pieces)-1]
 	r.Location = fmt.Sprintf(SourceFormat, name, r.Version)
 	return r