Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional feature tag for adaptive sampling #3648

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bm1549
Copy link
Contributor

@bm1549 bm1549 commented Dec 9, 2024

Motivation

Adaptive sampling requires various features across Dynamic Configuration and Trace Sampling to work. This PR adds a new feature for it so that we can see what does/doesn't work within a single feature

Note that this introduces two features on some classes. Let me know if this is/is not acceptable!

Changes

  • Adds a new feature adaptive.sampling
  • Adds that feature onto the existing classes that test required behavior

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@bm1549 bm1549 requested review from mabdinur and a team as code owners December 9, 2024 19:59
@bm1549 bm1549 force-pushed the bm1549/adaptive-sampling-feature branch from 1445142 to 76271f2 Compare December 10, 2024 19:36
@cbeauchesne
Copy link
Collaborator

Failure are not related, you can ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants