remove duplicate code in decorators

[mabdinur]

Motivation

• Clean up

Changes

• Removes duplicate code from missing_feature, incomplete_test_app, irrelevant, and flaky decorators
• Removes _get_skipped_item . _get_expected_failure_item can be used in all decorators.
• Simplifies the first if statement in _should_skip

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• If PR title starts with [<language>], double-check that only <language> is impacted by the change
• No system-tests internal is modified. Otherwise, I have the approval from R&P team
• CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added (or removed)?
  • Get a review from R&P team

[mabdinur]

Blocked by: https://github.com/DataDog/system-tests/pull/3551/files

[cbeauchesne]

rebasing to fix issue on python

[cbeauchesne]

CI is failing

[mabdinur]

CI is failing

The java parametric test failure was due to a flaky test. After one rerun that scenario is now green.

The php failures seem unrelated to this PR. The same tests are also failing on the main branch: https://github.com/DataDog/system-tests/actions/runs/12257217102/job/34195001337. We are mainly seeing failures on php-dev so it likely caused by a recent regression. Maybe this change: DataDog/dd-trace-php#2735?

cc: @cataphract

[cbeauchesne]

yep, for PHP : #3658

reviewing the PR

[cbeauchesne]

Using named argument will be easier to maintain

Suggested change

	return partial(decorator, expected_to_fail, force_skip, condition, "missing_feature", reason)
	return partial(decorator, expected_to_fail=expected_to_fail, force_skip=force_skip, condition=condition, decorator_type="missing_feature", reason=reason)

[mabdinur]

I can only use positional arguments in partial(..).

[cbeauchesne]

Same comment as above :

Suggested change

	force_skip = False
	return partial(decorator, expected_to_fail, force_skip, condition, "incomplete_test_app", reason)
	return partial(decorator, expected_to_fail=expected_to_fail, force_skip=False, condition=condition, decorator_type="incomplete_test_app", reason=reason)

[mabdinur]

We can only use positional arguments in partial(....)