Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: experimental approach for chaining chunks of tags for TagSet #131

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tobz
Copy link
Member

@tobz tobz commented Jul 23, 2024

Context

An attempt to address #127 through chaining chunks of tags (TagSetChunk) to form TagSet instead of always having to own/clone/allocate any time we do any mutation.

Currently a work in progress.

@github-actions github-actions bot added area/core Core functionality, event model, etc. area/config Configuration. area/components Sources, transforms, and destinations. transform/origin-enrichment Origin Enrichment synchronous transform. labels Jul 23, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 23, 2024

Regression Detector (Saluki)

Regression Detector Results

Run ID: 20e99755-6094-4ac0-9a35-5959fcf6f8e5

Baseline: a133936
Comparison: bf3f557

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI links
dsd_uds_100mb_3k_contexts_distributions_only memory utilization -6.08 [-6.25, -5.91]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
dsd_uds_1mb_50k_contexts ingress throughput +0.03 [+0.01, +0.06]
dsd_uds_100mb_3k_contexts ingress throughput +0.01 [-0.00, +0.03]
dsd_uds_50mb_10k_contexts_no_inlining ingress throughput +0.00 [-0.02, +0.02]
dsd_uds_50mb_10k_contexts_no_inlining_no_allocs ingress throughput +0.00 [-0.06, +0.06]
dsd_uds_1mb_3k_contexts ingress throughput -0.00 [-0.19, +0.19]
dsd_uds_100mb_250k_contexts ingress throughput -0.01 [-0.23, +0.22]
dsd_uds_10mb_3k_contexts ingress throughput -0.01 [-0.20, +0.17]
dsd_uds_512kb_3k_contexts ingress throughput -0.04 [-0.22, +0.15]
dsd_uds_500mb_3k_contexts ingress throughput -0.65 [-0.77, -0.54]
dsd_uds_1mb_50k_contexts_memlimit ingress throughput -1.43 [-3.86, +1.00]
dsd_uds_100mb_3k_contexts_distributions_only memory utilization -6.08 [-6.25, -5.91]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components Sources, transforms, and destinations. area/config Configuration. area/core Core functionality, event model, etc. transform/origin-enrichment Origin Enrichment synchronous transform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant