Validate operations on FileHandles #1113
Merged
+56
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows State to track whether a file handle is valid for read etc operations. Our GC mechanism keeps track of the open-handles but assumes the correctness of callers, meaning if multiple calls to `release` are made at the filesystem level a node may be GC'ed before its time. The State now keeps a record of which FileHandles exist and whether they remain valid, meaning the GC mechanism cannot be misled. REF SMPTNG-532 Signed-off-by: Brian L. Troutwine <[email protected]>
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
GeorgeHahn
reviewed
Nov 12, 2024
Comment on lines
1290
to
1292
| !valid_handles.is_empty(), | ||
| "Unlinked, read-only file with open handles should have valid file handles" | ||
| ); |
There was a problem hiding this comment.
Nit: indentation is off here
There was a problem hiding this comment.
So it is and cargo-fmt didn't catch it.
There was a problem hiding this comment.
Macros :( There was a google summer of code project that I think will improve this in the next few releases.
GeorgeHahn
approved these changes
Nov 12, 2024
Signed-off-by: Brian L. Troutwine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit allows State to track whether a file handle is valid for read etc
operations. Our GC mechanism keeps track of the open-handles but assumes the
correctness of callers, meaning if multiple calls to
releaseare made at thefilesystem level a node may be GC'ed before its time.
The State now keeps a record of which FileHandles exist and whether they remain
valid, meaning the GC mechanism cannot be misled.
Motivation
SMPTNG-531