Attempt to speed up container builds #1088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lading container build right now is roughly 1 hour. This is a very long loop to wait on. Introduce cargo-chef and more aggressive caching to hopefully cut this time. Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
|
As a smoke test, could you push a small code change? |
GeorgeHahn
reviewed
Nov 4, 2024
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
|
Does stripping the release binary help with compile time? I think its useful to preserve debug symbols as a general practice, unless there's a compelling reason. |
Yeah it shaves ~4 minutes off. The lading binary has gotten fairly big. On the whole, I'm meh on this change I think. It complicates the build non-trivially and it doesn't really improve build speed. An ARM build machine is what we need. |
blt
added a commit
that referenced
this pull request
Nov 6, 2024
This commit replaces #1088 and attempts to build a lading multi-platform image by use of organization provided ARM native builders. Unsure if this'll work but I figure it's worth a shot. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
added a commit
that referenced
this pull request
Nov 7, 2024
This commit replaces #1088 and attempts to build a lading multi-platform image by use of organization provided ARM native builders. Unsure if this'll work but I figure it's worth a shot. Signed-off-by: Brian L. Troutwine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The lading container build right now is roughly 1 hour. This is a very long loop to wait on. Introduce cargo-chef and more aggressive caching to hopefully cut this time.