Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-3305 remove dependency on benchmark #4259

Merged
merged 2 commits into from
Jan 7, 2025
Merged

DEBUG-3305 remove dependency on benchmark #4259

merged 2 commits into from
Jan 7, 2025

Conversation

p-datadog
Copy link
Member

What does this PR do?

Removes usage of Benchmark in DI code

Motivation:

Ruby warnings

Change log entry
None

Additional Notes:

How to test the change?

@p-datadog p-datadog requested a review from a team as a code owner January 6, 2025 19:10
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 6, 2025

Datadog Report

Branch report: di-benchmark
Commit report: 38551aa
Test service: dd-trace-rb

✅ 0 Failed, 22125 Passed, 1475 Skipped, 5m 33.48s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 6, 2025

Benchmarks

Benchmark execution time: 2025-01-07 15:45:24

Comparing candidate commit 38551aa in PR branch di-benchmark with baseline commit 9605f99 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (9605f99) to head (38551aa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4259      +/-   ##
==========================================
- Coverage   97.74%   97.74%   -0.01%     
==========================================
  Files        1353     1353              
  Lines       82392    82392              
  Branches     4224     4224              
==========================================
- Hits        80536    80532       -4     
- Misses       1856     1860       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-datadog p-datadog merged commit d5f88ea into master Jan 7, 2025
337 checks passed
@p-datadog p-datadog deleted the di-benchmark branch January 7, 2025 15:58
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants