Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using native metrics for newer node versions #4952

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Nov 27, 2024

What does this PR do?

Stop using native metrics for newer Node versions.

Motivation

All the runtime metrics we need are now available out of the box from Node, so loading a native extension is no longer necessary to capture them.

Copy link

github-actions bot commented Nov 27, 2024

Overall package size

Self size: 8.12 MB
Deduped: 94.62 MB
No deduping: 95.19 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Nov 28, 2024

Benchmarks

Benchmark execution time: 2024-11-28 17:38:00

Comparing candidate commit 1c2e122 in PR branch runtime-metrics-no-native with baseline commit ac19207 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 265 metrics, 1 unstable metrics.

@rochdev rochdev marked this pull request as ready for review November 28, 2024 00:28
@rochdev rochdev requested a review from a team as a code owner November 28, 2024 00:28
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 18.86792% with 43 lines in your changes missing coverage. Please review.

Project coverage is 62.20%. Comparing base (70a2c22) to head (e6a08ef).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/runtime_metrics.js 18.86% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4952      +/-   ##
==========================================
- Coverage   66.25%   62.20%   -4.06%     
==========================================
  Files         112      282     +170     
  Lines        3734    13157    +9423     
==========================================
+ Hits         2474     8184    +5710     
- Misses       1260     4973    +3713     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

juan-fernandez
juan-fernandez previously approved these changes Nov 28, 2024
Copy link
Contributor

@szegedi szegedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! One less native component to worry about.

packages/dd-trace/src/runtime_metrics.js Outdated Show resolved Hide resolved
@szegedi szegedi self-requested a review November 28, 2024 13:02
Copy link
Contributor

@szegedi szegedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! One less native component to worry about. I think there's one type tho'.

Co-authored-by: Attila Szegedi <[email protected]>
@rochdev
Copy link
Member Author

rochdev commented Nov 28, 2024

Turns out the Node implementation is invalid, so this PR cannot work. I will open an issue in Node, but I think their implementation will have to be completely rewritten for this to work.

@rochdev
Copy link
Member Author

rochdev commented Nov 28, 2024

Opened an issue in Node: nodejs/node#56064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants