-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove most usage of get-port for plugin tests #4429
Conversation
Overall package sizeSelf size: 6.71 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4429 +/- ##
==========================================
+ Coverage 92.64% 94.15% +1.51%
==========================================
Files 116 104 -12
Lines 4173 3389 -784
Branches 33 33
==========================================
- Hits 3866 3191 -675
+ Misses 307 198 -109 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-06-24 15:31:07 Comparing candidate commit de7a5ce in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 262 metrics, 4 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we ever use get-port?
e9e2947
to
de7a5ce
Compare
In some cases it was (and still is) needed, and also originally it was used to get a port before initializing the tracer. It ended up being way overused though, which is problematic as it can result in flaky tests. |
* remove most usage of get-port for plugins * remove get-port from instrumentation tests * fix new test
* remove most usage of get-port for plugins * remove get-port from instrumentation tests * fix new test
* remove most usage of get-port for plugins * remove get-port from instrumentation tests * fix new test
* remove most usage of get-port for plugins * remove get-port from instrumentation tests * fix new test
What does this PR do?
Remove most get-port usage in plugin tests.
Motivation
Follow-up of #4426