Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove most usage of get-port for plugin tests #4429

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jun 22, 2024

What does this PR do?

Remove most get-port usage in plugin tests.

Motivation

Follow-up of #4426

Copy link

github-actions bot commented Jun 22, 2024

Overall package size

Self size: 6.71 MB
Deduped: 61.97 MB
No deduping: 62.25 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.8.1 71.67 kB 741.34 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (b1f1f85) to head (99c19a7).
Report is 8 commits behind head on master.

Current head 99c19a7 differs from pull request most recent head de7a5ce

Please upload reports for the commit de7a5ce to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4429      +/-   ##
==========================================
+ Coverage   92.64%   94.15%   +1.51%     
==========================================
  Files         116      104      -12     
  Lines        4173     3389     -784     
  Branches       33       33              
==========================================
- Hits         3866     3191     -675     
+ Misses        307      198     -109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jun 22, 2024

Benchmarks

Benchmark execution time: 2024-06-24 15:31:07

Comparing candidate commit de7a5ce in PR branch plugins-remove-get-port with baseline commit 0ec0653 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 262 metrics, 4 unstable metrics.

@rochdev rochdev marked this pull request as ready for review June 22, 2024 19:10
@rochdev rochdev requested review from a team as code owners June 22, 2024 19:10
@rochdev rochdev requested a review from anmarchenko June 22, 2024 19:10
tlhunter
tlhunter previously approved these changes Jun 24, 2024
Copy link
Member

@tlhunter tlhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we ever use get-port?

@rochdev
Copy link
Member Author

rochdev commented Jun 24, 2024

Why did we ever use get-port?

In some cases it was (and still is) needed, and also originally it was used to get a port before initializing the tracer. It ended up being way overused though, which is problematic as it can result in flaky tests.

@rochdev rochdev merged commit 921cdc4 into master Jun 25, 2024
135 checks passed
@rochdev rochdev deleted the plugins-remove-get-port branch June 25, 2024 14:35
juan-fernandez pushed a commit that referenced this pull request Jul 10, 2024
* remove most usage of get-port for plugins

* remove get-port from instrumentation tests

* fix new test
juan-fernandez pushed a commit that referenced this pull request Jul 10, 2024
* remove most usage of get-port for plugins

* remove get-port from instrumentation tests

* fix new test
juan-fernandez pushed a commit that referenced this pull request Jul 11, 2024
* remove most usage of get-port for plugins

* remove get-port from instrumentation tests

* fix new test
juan-fernandez pushed a commit that referenced this pull request Jul 11, 2024
* remove most usage of get-port for plugins

* remove get-port from instrumentation tests

* fix new test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants