Standalone ASM priority sampler and tag propagation #4416

iunanua · 2024-06-19T13:45:59Z

What does this PR do?

Continuation of #4291

Defines two new channels in opentracing/propagation/text_map.js in order to alter trace propagation:

dd-trace:span:inject which publishes the trace span context and the carrier that is going to be injected in a downstream req
dd-trace:span:extract which publishes the trace span context and the carrier when a span is going to be extracted from an upstream req.

When standalone ASM is enabled it:

replaces default PrioritySampler with StandaloneAsmPrioritySampler via DatadogTracer constructor.
- StandaloneAsmPrioritySampler searches for _dd.p.appsec in the tags in order to keep a trace, sets a 1 req/min rate limiter and disables user rules.
when injecting a trace and if the trace doesn't contain _dd.p.appsec tag, removes x-datadog- and datadog info from tracestate
when extracting a trace if the trace doesn't contain _dd.p.appsec tag, resets the sampling priority.
disables span stats and includes 'Datadog-Client-Computed-Stats': 'yes' header when exporting traces to the agent to pretend stats computation is made by the tracer

ST PR to enable Standalone ASM tests

Motivation

Support Standalone ASM billing

Plugin Checklist

Additional Notes

Co-authored-by: Ugaitz Urien <[email protected]>

Co-authored-by: simon-id <[email protected]>

packages/dd-trace/src/proxy.js

integration-tests/standalone-asm/index.js

integration-tests/standalone-asm.spec.js

packages/dd-trace/test/exporters/agent/exporter.spec.js

packages/dd-trace/src/appsec/standalone.js

packages/dd-trace/test/appsec/standalone.spec.js

Co-authored-by: simon-id <[email protected]>

* DD_APM_TRACING_ENABLED and span _dd.apm.enabled tag * clean up * Use MANUAL_KEEP const * Add _dd.p.appsec tag on standalone ASM events * Include apmTracingEnabled checks * Appsec Reporter tests * Appsec sdk track_event test * Use numeric value for _dd.p.appsec * Include appsec standalone config in .ts files * Clean up null and undefined values * Remove not needed config properties * standalone module * Clean up * standalone proxy test * Update packages/dd-trace/test/appsec/iast/vulnerability-reporter.spec.js Co-authored-by: Ugaitz Urien <[email protected]> * appsec reporter test * Use standalone singletone in vulnerability-reporter * continue applying ratelimiter on appsec standalone events * Update packages/dd-trace/src/appsec/reporter.js Co-authored-by: simon-id <[email protected]> * Add _dd.apm.enabled:0 in root spans with remote parent * Use a method to add the tag * Remove apmTracingEnabled config property * Add _dd.p.appsec tag in trace tags * Some tests * Set _dd.apm.enabled in root span * configure standalone if _tracingInitialized * Use dd-trace:span:start channel * PrioritySampler and propagation * Clean up * Clean up * use a meta tag * Use dc to modify what is injected and extracted * set USER_KEEP priority * integration tests * hasSubscribers check * test description * hasSubscribers check * standalone tests * Check span context has tags before using them and check if config has changed * clean up * Pass prioritySampler as argument to DatadogTracer * clean up * clean up * protect span context sampling access * Disable span stats if standalone enabled * clean up * clean up * Clean up * Clean up * clean up * Remove all headers from carrier * inject integration tests * remove only * Update packages/dd-trace/test/appsec/sdk/track_event.spec.js Co-authored-by: Ugaitz Urien <[email protected]> * Update packages/dd-trace/test/appsec/standalone.spec.js Co-authored-by: Ugaitz Urien <[email protected]> * protect sample method * Use assert instead expect * reset sampling prio * unsubscribe after test * clear dd context from tracestate * propagation with and without ASM events * suggestions * test inject and extrach channels * use two services to test propagation * integration tests cleanup * clean up * clean up * Update packages/dd-trace/src/priority_sampler.js Co-authored-by: Ugaitz Urien <[email protected]> * Update packages/dd-trace/src/appsec/standalone.js Co-authored-by: Ugaitz Urien <[email protected]> * Move hasOwn, remove not used argument and fix test * simplify iast integration-test using weak_hash * Update packages/dd-trace/src/appsec/standalone.js Co-authored-by: Ugaitz Urien <[email protected]> * suggestions * Fix integration tests * Update packages/dd-trace/test/span_stats.spec.js Co-authored-by: Ugaitz Urien <[email protected]> * Update packages/dd-trace/test/exporters/agent/exporter.spec.js Co-authored-by: Ugaitz Urien <[email protected]> * Remove redundant check * Remove standalone option * protect onSpanInject and onSpanExtract * do not set _dd.p.dm * remove _dd.p.dm check from integration tests * increase coverage * increase coverage * more coverage * remove not needed async * set default mechanism * sugestions * Remove throw tests * Remove throw tests * Update packages/dd-trace/test/appsec/standalone.spec.js Co-authored-by: simon-id <[email protected]> --------- Co-authored-by: Ugaitz Urien <[email protected]> Co-authored-by: simon-id <[email protected]>

iunanua and others added 30 commits May 9, 2024 11:53

DD_APM_TRACING_ENABLED and span _dd.apm.enabled tag

f14601e

clean up

2817602

Use MANUAL_KEEP const

957760a

Add _dd.p.appsec tag on standalone ASM events

5d6210d

Include apmTracingEnabled checks

089c26d

Appsec Reporter tests

18d9fef

Appsec sdk track_event test

d903394

Use numeric value for _dd.p.appsec

736014a

Include appsec standalone config in .ts files

396a8fc

Clean up null and undefined values

cb73c58

Merge branch 'master' into igor/standalone-asm-config-and-tags

67b171a

Remove not needed config properties

460d773

standalone module

31f8951

Clean up

0b8a067

standalone proxy test

dc1b7b9

Update packages/dd-trace/test/appsec/iast/vulnerability-reporter.spec.js

626bbfa

Co-authored-by: Ugaitz Urien <[email protected]>

appsec reporter test

d989a73

Use standalone singletone in vulnerability-reporter

7734ae7

continue applying ratelimiter on appsec standalone events

0ba2f3d

Update packages/dd-trace/src/appsec/reporter.js

4518d52

Co-authored-by: simon-id <[email protected]>

Add _dd.apm.enabled:0 in root spans with remote parent

167d5d5

Use a method to add the tag

6f328fe

Remove apmTracingEnabled config property

3627b99

Merge branch 'master' into igor/standalone-asm-config-and-tags

9a2a105

Add _dd.p.appsec tag in trace tags

e57525d

Some tests

b15c51c

Set _dd.apm.enabled in root span

5554ff7

configure standalone if _tracingInitialized

f658168

Use dd-trace:span:start channel

53b1dc0

PrioritySampler and propagation

366d2a7

more coverage

3288f77

simon-id reviewed Jun 26, 2024

View reviewed changes

packages/dd-trace/src/proxy.js Show resolved Hide resolved

iunanua marked this pull request as ready for review June 27, 2024 15:04

iunanua requested review from a team as code owners June 27, 2024 15:04

simon-id reviewed Jun 28, 2024

View reviewed changes

integration-tests/standalone-asm/index.js Show resolved Hide resolved

simon-id reviewed Jun 28, 2024

View reviewed changes

integration-tests/standalone-asm/index.js Outdated Show resolved Hide resolved

remove not needed async

adfae02

simon-id reviewed Jul 1, 2024

View reviewed changes

integration-tests/standalone-asm.spec.js Outdated Show resolved Hide resolved

simon-id reviewed Jul 1, 2024

View reviewed changes

packages/dd-trace/test/exporters/agent/exporter.spec.js Outdated Show resolved Hide resolved

simon-id reviewed Jul 2, 2024

View reviewed changes

packages/dd-trace/src/appsec/standalone.js Show resolved Hide resolved

simon-id reviewed Jul 2, 2024

View reviewed changes

packages/dd-trace/src/appsec/standalone.js Outdated Show resolved Hide resolved

simon-id reviewed Jul 2, 2024

View reviewed changes

packages/dd-trace/test/appsec/standalone.spec.js Outdated Show resolved Hide resolved

iunanua added 2 commits July 2, 2024 11:09

set default mechanism

ccca78c

sugestions

9a8f4e8

simon-id reviewed Jul 2, 2024

View reviewed changes

packages/dd-trace/test/appsec/standalone.spec.js Outdated Show resolved Hide resolved

iunanua and others added 4 commits July 2, 2024 14:12

Remove throw tests

5ab27e7

Remove throw tests

f615a16

Update packages/dd-trace/test/appsec/standalone.spec.js

ea548ea

Co-authored-by: simon-id <[email protected]>

Merge branch 'master' into igor/standalone-asm-priority-sampler-channel

61f7b11

simon-id approved these changes Jul 3, 2024

View reviewed changes

Qard approved these changes Jul 3, 2024

View reviewed changes

iunanua merged commit 7997564 into master Jul 5, 2024
157 checks passed

iunanua deleted the igor/standalone-asm-priority-sampler-channel branch July 5, 2024 08:47

This was referenced Jul 10, 2024

v5.18.0 #4496

Merged

v4.42.0 #4497

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Standalone ASM priority sampler and tag propagation #4416

Standalone ASM priority sampler and tag propagation #4416

iunanua commented Jun 19, 2024 •

edited

Loading

Standalone ASM priority sampler and tag propagation #4416

Standalone ASM priority sampler and tag propagation #4416

Conversation

iunanua commented Jun 19, 2024 • edited Loading

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

iunanua commented Jun 19, 2024 •

edited

Loading