-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect request headers on user event #4385
Conversation
Overall package sizeSelf size: 6.72 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4385 +/- ##
===========================================
- Coverage 80.42% 63.31% -17.12%
===========================================
Files 3 245 +242
Lines 373 10441 +10068
Branches 33 33
===========================================
+ Hits 300 6611 +6311
- Misses 73 3830 +3757 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-06-24 12:39:20 Comparing candidate commit 1916bd6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 262 metrics, 4 unstable metrics. |
aa55b46
to
ccac65a
Compare
Co-authored-by: Carles Capell <[email protected]>
Co-authored-by: simon-id <[email protected]>
Co-authored-by: simon-id <[email protected]>
--------- Co-authored-by: Carles Capell <[email protected]> Co-authored-by: simon-id <[email protected]>
--------- Co-authored-by: Carles Capell <[email protected]> Co-authored-by: simon-id <[email protected]>
--------- Co-authored-by: Carles Capell <[email protected]> Co-authored-by: simon-id <[email protected]>
--------- Co-authored-by: Carles Capell <[email protected]> Co-authored-by: simon-id <[email protected]>
What does this PR do?
This PR changes the moment when the headers are added to the root span, instead of adding them when the threat is detected, they are added when the request ends, because we should send headers also when user login event happens.
Few headers are added in the root span always, even though there is no asm event.
Motivation
To apply the last spec changes, we should send headers not only when a threat is detected, we should send headers also when an user event is detected. Some other headers should be sent when appsec is enabled, with or without threat or user event.
Plugin Checklist
Additional Notes
System tests PR: DataDog/system-tests#2541
APPSEC-52884