Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect request headers on user event #4385

Merged
merged 12 commits into from
Jun 27, 2024

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Jun 6, 2024

What does this PR do?

This PR changes the moment when the headers are added to the root span, instead of adding them when the threat is detected, they are added when the request ends, because we should send headers also when user login event happens.

Few headers are added in the root span always, even though there is no asm event.

Motivation

To apply the last spec changes, we should send headers not only when a threat is detected, we should send headers also when an user event is detected. Some other headers should be sent when appsec is enabled, with or without threat or user event.

Plugin Checklist

  • Unit tests.

Additional Notes

System tests PR: DataDog/system-tests#2541

APPSEC-52884

Copy link

github-actions bot commented Jun 6, 2024

Overall package size

Self size: 6.72 MB
Deduped: 61.98 MB
No deduping: 62.26 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.8.1 71.67 kB 741.34 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 63.31%. Comparing base (5278b1c) to head (aa55b46).
Report is 12 commits behind head on master.

Current head aa55b46 differs from pull request most recent head 465e1e0

Please upload reports for the commit 465e1e0 to get more accurate results.

Files Patch % Lines
packages/dd-trace/src/appsec/reporter.js 10.52% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4385       +/-   ##
===========================================
- Coverage   80.42%   63.31%   -17.12%     
===========================================
  Files           3      245      +242     
  Lines         373    10441    +10068     
  Branches       33       33               
===========================================
+ Hits          300     6611     +6311     
- Misses         73     3830     +3757     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jun 6, 2024

Benchmarks

Benchmark execution time: 2024-06-24 12:39:20

Comparing candidate commit 1916bd6 in PR branch ugaitz/collect-headers-on-user-event with baseline commit fec9a91 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 262 metrics, 4 unstable metrics.

@uurien uurien force-pushed the ugaitz/collect-headers-on-user-event branch from aa55b46 to ccac65a Compare June 10, 2024 08:56
@uurien uurien marked this pull request as ready for review June 11, 2024 10:03
@uurien uurien requested a review from a team as a code owner June 11, 2024 10:03
CarlesDD
CarlesDD previously approved these changes Jun 13, 2024
@uurien uurien merged commit 6589bcc into master Jun 27, 2024
135 checks passed
@uurien uurien deleted the ugaitz/collect-headers-on-user-event branch June 27, 2024 07:26
juan-fernandez pushed a commit that referenced this pull request Jul 10, 2024
---------

Co-authored-by: Carles Capell <[email protected]>
Co-authored-by: simon-id <[email protected]>
juan-fernandez pushed a commit that referenced this pull request Jul 10, 2024
---------

Co-authored-by: Carles Capell <[email protected]>
Co-authored-by: simon-id <[email protected]>
This was referenced Jul 10, 2024
juan-fernandez pushed a commit that referenced this pull request Jul 11, 2024
---------

Co-authored-by: Carles Capell <[email protected]>
Co-authored-by: simon-id <[email protected]>
juan-fernandez pushed a commit that referenced this pull request Jul 11, 2024
---------

Co-authored-by: Carles Capell <[email protected]>
Co-authored-by: simon-id <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants