Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JNR dependencies to pick up fix for GLIBC minimum version #6749

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Feb 28, 2024

Motivation

Pick up fix for jnr/jffi#138

@mcculls mcculls added the tag: dependencies Dependencies related changes label Feb 28, 2024
@PerfectSlayer
Copy link
Contributor

Additional notes

This PR is a follow up of #6635 issue.

@mcculls mcculls marked this pull request as ready for review February 28, 2024 09:45
@mcculls mcculls requested a review from a team as a code owner February 28, 2024 09:45
@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/jnr-glibc-version-fix
git_commit_date 1709101358 1709112077
git_commit_sha 0c76db1 e435524
release_version 1.31.0-SNAPSHOT~0c76db1530 1.31.0-SNAPSHOT~e4355249c0
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709115122 1709115122
ci_job_id 445526085 445526085
ci_pipeline_id 29099940 29099940
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 12 unstable metrics.

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-28T09:48:26 2024-02-28T10:07:01
git_branch master mcculls/jnr-glibc-version-fix
git_commit_date 1709101358 1709112077
git_commit_sha 0c76db1 e435524
release_version 1.31.0-SNAPSHOT~0c76db1530 1.31.0-SNAPSHOT~e4355249c0
start_time 2024-02-28T09:48:13 2024-02-28T10:06:48
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709115122 1709115122
ci_job_id 445526085 445526085
ci_pipeline_id 29099940 29099940
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~e4355249c0, baseline=1.31.0-SNAPSHOT~0c76db1530
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.311 µs) : 346, 388
.   : milestone, 367,
iast (471.42 µs) : 451, 492
.   : milestone, 471,
iast_FULL (537.551 µs) : 517, 558
.   : milestone, 538,
iast_GLOBAL (500.629 µs) : 479, 522
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (471.678 µs) : 451, 492
.   : milestone, 472,
iast_INACTIVE (445.381 µs) : 425, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (461.588 µs) : 441, 482
.   : milestone, 462,
tracing (441.002 µs) : 420, 462
.   : milestone, 441,
section candidate
no_agent (364.975 µs) : 345, 385
.   : milestone, 365,
iast (474.943 µs) : 454, 496
.   : milestone, 475,
iast_FULL (536.497 µs) : 516, 557
.   : milestone, 536,
iast_GLOBAL (490.122 µs) : 470, 510
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (471.931 µs) : 451, 493
.   : milestone, 472,
iast_INACTIVE (446.251 µs) : 425, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (469.365 µs) : 448, 490
.   : milestone, 469,
tracing (440.514 µs) : 420, 461
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.311 µs [346.423 µs, 388.2 µs] -
iast 471.42 µs [451.028 µs, 491.813 µs] 104.109 µs (28.3%)
iast_FULL 537.551 µs [517.057 µs, 558.045 µs] 170.24 µs (46.3%)
iast_GLOBAL 500.629 µs [479.293 µs, 521.965 µs] 133.318 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED 471.678 µs [451.302 µs, 492.054 µs] 104.367 µs (28.4%)
iast_INACTIVE 445.381 µs [424.558 µs, 466.204 µs] 78.07 µs (21.3%)
iast_TELEMETRY_OFF 461.588 µs [441.409 µs, 481.768 µs] 94.277 µs (25.7%)
tracing 441.002 µs [420.311 µs, 461.693 µs] 73.691 µs (20.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.975 µs [345.18 µs, 384.77 µs] -
iast 474.943 µs [454.364 µs, 495.522 µs] 109.968 µs (30.1%)
iast_FULL 536.497 µs [516.15 µs, 556.845 µs] 171.522 µs (47.0%)
iast_GLOBAL 490.122 µs [469.82 µs, 510.424 µs] 125.147 µs (34.3%)
iast_HARDCODED_SECRET_DISABLED 471.931 µs [451.312 µs, 492.55 µs] 106.955 µs (29.3%)
iast_INACTIVE 446.251 µs [425.393 µs, 467.11 µs] 81.276 µs (22.3%)
iast_TELEMETRY_OFF 469.365 µs [448.438 µs, 490.292 µs] 104.39 µs (28.6%)
tracing 440.514 µs [420.157 µs, 460.87 µs] 75.538 µs (20.7%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~e4355249c0, baseline=1.31.0-SNAPSHOT~0c76db1530
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1366
.   : milestone, 1347,
appsec (1.76 ms) : 1736, 1784
.   : milestone, 1760,
iast (1.506 ms) : 1482, 1529
.   : milestone, 1506,
profiling (1.516 ms) : 1492, 1540
.   : milestone, 1516,
tracing (1.503 ms) : 1479, 1526
.   : milestone, 1503,
section candidate
no_agent (1.347 ms) : 1329, 1366
.   : milestone, 1347,
appsec (1.778 ms) : 1755, 1802
.   : milestone, 1778,
iast (1.531 ms) : 1508, 1554
.   : milestone, 1531,
profiling (1.555 ms) : 1531, 1580
.   : milestone, 1555,
tracing (1.513 ms) : 1490, 1537
.   : milestone, 1513,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.328 ms, 1.366 ms] -
appsec 1.76 ms [1.736 ms, 1.784 ms] 413.365 µs (30.7%)
iast 1.506 ms [1.482 ms, 1.529 ms] 159.136 µs (11.8%)
profiling 1.516 ms [1.492 ms, 1.54 ms] 169.136 µs (12.6%)
tracing 1.503 ms [1.479 ms, 1.526 ms] 155.832 µs (11.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.329 ms, 1.366 ms] -
appsec 1.778 ms [1.755 ms, 1.802 ms] 430.795 µs (32.0%)
iast 1.531 ms [1.508 ms, 1.554 ms] 183.598 µs (13.6%)
profiling 1.555 ms [1.531 ms, 1.58 ms] 207.948 µs (15.4%)
tracing 1.513 ms [1.49 ms, 1.537 ms] 165.819 µs (12.3%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: dependencies Dependencies related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants