Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the test plan for the Lambda Extension to README.md #170

Merged

Conversation

yshapiro-57
Copy link
Collaborator

@yshapiro-57 yshapiro-57 commented Sep 26, 2023

While testing the changes I made for this Jira task, I had to follow a test plan to run build_binary_and_layer_dockerized.sh to build a local version of the Lambda extension and then deploy it with a dummy serverless app to make sure it behaves as expected. In this PR I am adding this plan to README.md for the repo, so that other people who touch the Lambda extension know to follow the same steps.

For testing, I inspected the new README.md here and clicked all of the links in the Testing section to make sure they take me to the right places.

@yshapiro-57 yshapiro-57 marked this pull request as ready for review September 26, 2023 18:09
@yshapiro-57 yshapiro-57 requested a review from a team as a code owner September 26, 2023 18:09
README.md Outdated
@@ -39,6 +39,29 @@ You can also open an issue for a feature request.

If you find an issue with this package and have a fix, please feel free to open a pull request following the [procedures](https://github.com/DataDog/datadog-agent/blob/master/docs/dev/contributing.md).

## Testing

To test a change to the Datadog Lambda Extension:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should specify that these instructions are just for testing in cloudrun. The process will be different when using aws lambda.

@yshapiro-57 yshapiro-57 merged commit 90ae1e1 into main Sep 26, 2023
4 checks passed
@yshapiro-57 yshapiro-57 deleted the yakov.shapiro/include-testing-instructions-in-readme branch September 26, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants