Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes based on BDD testing #7

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Bugfixes based on BDD testing #7

merged 6 commits into from
Jan 17, 2024

Conversation

nkzou
Copy link
Collaborator

@nkzou nkzou commented Jan 11, 2024

misc fixes

  • re-adds default trait for models with all-optional fields
  • changes templating engine to use minijinja
  • nullables getting improperly propagated to child models
  • api tag capitalization
  • arbitrary json fields being mixed up by additionalproperties maps
  • undo operation bodies skipping serialization
  • inner object ordering with btreemap instead of hashmap
  • add cross-version given/undo statements
  • add dynamic given statements to the bdd runner
  • initialization of undo api instances (for service account undo, which uses user api)
  • inline oneOfs and simplify types (stop Boxing primitive types and arrays)

Base automatically changed from kevinzou/oneOfs to master January 17, 2024 18:55
@nkzou nkzou force-pushed the kevinzou/bdd_bugfix branch from 68bab6c to ff2ef88 Compare January 17, 2024 19:00
Copy link
Member

@skarimo skarimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good. We can rework the givens in a future PR

@nkzou nkzou merged commit 2c12a0a into master Jan 17, 2024
4 checks passed
@nkzou nkzou deleted the kevinzou/bdd_bugfix branch January 17, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants