Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cassette record/replay/passthrough modes in bdd runner #4

Merged
merged 11 commits into from
Nov 2, 2023

Conversation

nkzou
Copy link
Collaborator

@nkzou nkzou commented Oct 24, 2023

uses https://github.com/ChorusOne/rvcr, but currently I'm pointing the cargo dependency at a personal fork of mine that includes custom request matching functionality, along with another person's PR with custom filtering.

works with modified cassettes from datadog-api-client-ruby

  1. yaml -> json (structurally equivalent, but rvcr only supports json for now.)
  2. lowercased http method
  3. null'd body encoding
  4. headers are currently ignored, TODO update the custom matcher to match on a whitelist of headers.

@nkzou nkzou changed the base branch from master to kevinzou/api_client_pattern October 24, 2023 21:30
therve
therve previously approved these changes Nov 2, 2023
Base automatically changed from kevinzou/api_client_pattern to master November 2, 2023 13:50
@nkzou nkzou dismissed therve’s stale review November 2, 2023 13:50

The base branch was changed.

@nkzou nkzou merged commit a429ffa into master Nov 2, 2023
4 checks passed
@nkzou nkzou deleted the kevinzou/rvcr branch November 2, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants