Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAOSPLT-531: Add a config for the minimum cron frequency #941

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ptnapoleon
Copy link
Contributor

@ptnapoleon ptnapoleon commented Dec 3, 2024

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

  • One might consider a disruption that runs every minute to be too often. One might even want to prevent that. Now we can!

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 3, 2024

Datadog Report

Branch report: philip/chaosplt-531
Commit report: ecfa535
Test service: chaos-controller

✅ 0 Failed, 979 Passed, 8 Skipped, 25m 44.18s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • [It] Disruption Controller dont duplicate targets across disruptions should target all the selected pods - Controller Suite - Last Failure

    Expand for error
     A grace period timeout occurred
     
     [TIMEDOUT] A grace period timeout occurred
     In [DeferCleanup (Each)] at: /home/circleci/go/src/github.com/DataDog/chaos-controller/controllers/suite_toolsfor_test.go:217 @ 12/04/24 16:48:55.888
     
     This is the Progress Report generated when the grace period timeout occurred:
       Disruption Controller dont duplicate targets across disruptions should target all the selected pods (Spec Runtime: 16m56.011s)
         /home/circleci/go/src/github.com/DataDog/chaos-controller/controllers/disruption_controller_test.go:255
         In [DeferCleanup (Each)] (Node Runtime: 30.001s)
           /home/circleci/go/src/github.com/DataDog/chaos-controller/controllers/suite_toolsfor_test.go:217
     ...
    

@ptnapoleon ptnapoleon marked this pull request as ready for review December 4, 2024 17:35
@ptnapoleon ptnapoleon requested a review from a team as a code owner December 4, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant