Force refresh before IncreaseSize #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenicbozzuto
force-pushed
the
dom.bozzuto/azure-force-refresh-on-scaleup
branch
from
4461ff2 to
6c8a68e
Compare
domenicbozzuto
force-pushed
the
dom.bozzuto/azure-force-refresh-on-scaleup
branch
from
6c8a68e to
00e7281
Compare
bpineau
approved these changes
Jun 25, 2024
domenicbozzuto
force-pushed
the
dom.bozzuto/azure-force-refresh-on-scaleup
branch
from
00e7281 to
15f6d76
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option
AZURE_VMSS_CACHE_FORCE_REFRESHto force the refresh of the VMSS cache (not VMSS VMs cache per scale set) before an upscale is triggered. This ensures that the size that will be considered during the upscale is up to date, and minimizes the potential for skew in accounting by relying onscaleSet.curSize.This also adds a check and some more logging on the upscale path to ensure that an 'upscale' to a size that's lower than the current size is never attempted, as this would always delete random instances.