[vertical-pod-autoscaler] Add AllowedResourceFilter to restrict which recommendations can be applied #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenicbozzuto
force-pushed
the
dom.bozzuto/allowed-resource-recommendation-processor
branch
from
7597a3c to
8e98976
Compare
domenicbozzuto
changed the title
dbenque
reviewed
Feb 27, 2024
vertical-pod-autoscaler/pkg/utils/vpa/allowed_resource_filter_test.go
Outdated
Show resolved
Hide resolved
dbenque
approved these changes
Feb 27, 2024
…e applied by the admission controller
domenicbozzuto
force-pushed
the
dom.bozzuto/allowed-resource-recommendation-processor
branch
from
8e98976 to
9c3dab3
Compare
domenicbozzuto
deleted the
dom.bozzuto/allowed-resource-recommendation-processor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new recommendation post-processor that restricts which recommended resources can actually be applied to a pod. This is useful for preventing new/experimental recommendations from immediately being applied, as well as preventing intermediate values without a backing extended resource from being applied.
It's implemented as a RecommendationProcessor; I'm using the existing (but previously unused) SequentialProcessor to hook in the Capping processor (which was previously the only RecommendationProcessor used) and this new AllowedResourceFilter.
It's gated by a command line option
--allowed-resourcesin both the updater and admission controller. By default, this should be no change from the current behavior where only cpu/memory are applied.