Skip to content

Commit

Permalink
fix: renamed Error to MyError (#4309)
Browse files Browse the repository at this point in the history
  • Loading branch information
jpaten committed Jan 3, 2025
1 parent 72f9cf3 commit 3af7f35
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion pages/[entityListType]/[...params].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ export default EntityDetailPage;
* @returns catalog prefix.
*/
function getCatalogPrefix(defaultCatalog: string): string {
//eslint-disable-next-line sonarjs/slow-regex -- catalog numbers should be short and are user provided
//eslint-disable-next-line sonarjs/slow-regex -- catalog numbers should be short and are not user provided
return defaultCatalog.replace(/\d.*$/, ""); //TODO - are all catalog numbers less than a maximum length? could remove eslint ignore
}

Expand Down
7 changes: 3 additions & 4 deletions pages/_error.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ interface ErrorProps {
error?: Error | null;
}

// eslint-disable-next-line sonarjs/no-globals-shadowing -- TODO not sure of reason for this
const Error: NextPage<ErrorProps> = ({ error }: ErrorProps) => {
const MyError: NextPage<ErrorProps> = ({ error }: ErrorProps) => {
const { config } = useConfig();

return error ? (
Expand All @@ -17,8 +16,8 @@ const Error: NextPage<ErrorProps> = ({ error }: ErrorProps) => {
);
};

Error.getInitialProps = ({ err }: NextPageContext): ErrorProps => {
MyError.getInitialProps = ({ err }: NextPageContext): ErrorProps => {
return { error: err };
};

export default Error;
export default MyError;
2 changes: 1 addition & 1 deletion playwright_anvil.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ const config: PlaywrightTestConfig = {
timeout: 240 * 1000,
url: "http://localhost:3000/",
},
workers: "50%",
workers: "75%",
};
export default config;

0 comments on commit 3af7f35

Please sign in to comment.