feat: Add ability to define priorityClassName globally #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkilchhofer
force-pushed
the
feature/redis-ha_global_priorityClassName
branch
from
0af5f4f to
3ad4554
Compare
|
@mkilchhofer Sorry for not getting back to you on this, I've been out of the country. Checking now! |
DandyDeveloper
requested changes
May 26, 2024
| @@ -5,7 +5,7 @@ keywords: | |||
| - redis | |||
| - keyvalue | |||
| - database | |||
| version: 4.26.6 | |||
There was a problem hiding this comment.
That's quite a jump? CI might reject with this now being an increment of 1.
There was a problem hiding this comment.
Ohh :D sorry, my bad. I fixed it
Signed-off-by: Marco Maurer <[email protected]>
mkilchhofer
force-pushed
the
feature/redis-ha_global_priorityClassName
branch
from
3ad4554 to
55877c8
Compare
DandyDeveloper
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Context is this feature request over there:
.Values.global.xyzis a reserved section which is passed to all dependency charts inside a helm chart (also called subcharts).Implementing this is useful for both
redis-haas a dependency chart (like we do in argoproj/argo-helm)Which issue this PR fixes
Partially this one over there:
Special notes for your reviewer:
Other well-known charts implementing this:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])