redis-ha: add custom command and args for sentinel container #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bootc Looks great. Thank you! Can you pull in master and bump the patch again? |
bootc
force-pushed
the
sentinel-custom-command-args
branch
from
aca6fbe to
dbce2bc
Compare
|
@DandyDeveloper I've rebased against current |
Signed-off-by: Chris Boot <[email protected]>
bootc
force-pushed
the
sentinel-custom-command-args
branch
from
dbce2bc to
e5dbc26
Compare
|
@DandyDeveloper sorry for pinging you after bootc did but is there a reason you have not come up with an approving review? |
|
@nico151999 Nope, just missed the emails. |
DandyDeveloper
approved these changes
Jul 16, 2024
|
Sometimes things are as easy as that. Thanks for the quick response! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows overriding the command and arguments for the sentinel container.
Special notes for your reviewer:
I'm trying to run Valkey with this chart, and the sentinel container needs a custom command/args to work correctly.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])