[stable/redis-ha] add maxUnavailable value for the ha-proxy rollingUpdate config #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvdp
force-pushed
the
redis-ha/ha-proxy/add-rollout-strategy-config
branch
from
0bb953c to
37a363a
Compare
martijnvdp
force-pushed
the
redis-ha/ha-proxy/add-rollout-strategy-config
branch
3 times, most recently
from
1afbece to
0b628cd
Compare
…date config, fix issue DandyDeveloper#249. Signed-off-by: Martijn van der Ploeg <[email protected]>
martijnvdp
force-pushed
the
redis-ha/ha-proxy/add-rollout-strategy-config
branch
from
0b628cd to
08ba4a9
Compare
DandyDeveloper
previously approved these changes
Feb 5, 2024
|
Easy win. @martijnvdp Sorry for the neglect. Getting this merged as soon as the checks finish. |
DandyDeveloper
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add a new variable
.Values.haproxy.rollingUpdate.maxUnavailablewith default value 1this is needed to be able to restart the deployment on a cluster with 3 or less nodes
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])